Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent and reproducible IDs for delineated events #35

Closed
mikoontz opened this issue Mar 1, 2021 · 3 comments
Closed

consistent and reproducible IDs for delineated events #35

mikoontz opened this issue Mar 1, 2021 · 3 comments

Comments

@mikoontz
Copy link

mikoontz commented Mar 1, 2021

Hi firedpy team,

Great product! Thanks for making the algorithm reusable. I have a general feature request, and it seems that #33 from @admahood is one specific way to implement it.

As folks start using this algorithm to build event databases beyond the spatiotemporal scope of the original publication of the dataset (https://scholar.colorado.edu/concern/datasets/nv935382p), it would be helpful to ensure that the unique identifiers of the events can be reproduced. For example, the currently published dataset goes through January of 2019 and covers CONUS, but rerunning the algorithm for just February of 2019 to present would (presumably) generate new unique IDs that overlap with the ones already published. That will make it more difficult to join datasets created with firedpy with other fire data (e.g., MTBS, the FRAP perimeters, FPA-FOD) if the FIRED unique identifiers change with each algorithm run.

One idea is to include some metadata associated with each event in the ID. The year, month, and MODIS tile seem like good candidates here, since those are the minimum units of time and space in which the MODIS burned area product are delivered. On second thought, since the algorithm could be based on products other than MODIS burned area, maybe Adam's approach to using the centroid coordinates and event start datetime makes more sense (though you could also include the datetime and centroid in the ID in addition to a random string for readability).

I suppose the short way of saying this is that I think this thought of Adam's might be more important than he gives himself credit for!

@mikoontz mikoontz changed the title consistent and reproducible IDs for fire events consistent and reproducible IDs for delineated events Mar 1, 2021
@lisestdenis
Copy link
Collaborator

lisestdenis commented Mar 1, 2021 via email

@admahood
Copy link
Collaborator

admahood commented Mar 1, 2021

Right on. I think it might be a good idea to think about that now as well, especially considering we just re-ran firedpy going to 2020, and Max and I were thinking about updating it on CU scholar. If it turns out that updating the code to include location and time-based metadata within the event IDs doesn't take a ton of time, it might be a good idea to do that now and have those new IDs in the next CU scholar update

@mikoontz
Copy link
Author

mikoontz commented Jul 9, 2021

Looks like this is done now, and can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants