Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

Minor refactoring in rdf_entity_update_8004() #142

Open
donquixote opened this issue Dec 13, 2021 · 0 comments
Open

Minor refactoring in rdf_entity_update_8004() #142

donquixote opened this issue Dec 13, 2021 · 0 comments

Comments

@donquixote
Copy link

donquixote commented Dec 13, 2021 •
edited
Loading

Some minor changes..
Follow-up to idimopoulos#3 and idimopoulos#4 by @golddragon007
(I like to have issue number for my commit messages)

Please merge idimopoulos#4 first!

Related to #141
donquixote added a commit to donquixote/rdf_entity that referenced this issue Dec 13, 2021
@donquixote
Github issue ec-europa#142: Replace redundant with comment.
4448047
donquixote added a commit to donquixote/rdf_entity that referenced this issue Dec 13, 2021
@donquixote
Github issue ec-europa#142: Use \Drupal::service() instead of \Drupal…
4da0e21 
…::getContainer()->get().

We are already not using dependency injection (normal in procedural code), so we can as well use the shortcut.
donquixote added a commit to donquixote/rdf_entity that referenced this issue Dec 13, 2021
@donquixote
Github issue ec-europa#142: Add inline doc on services.
250e80e 
This allows static analysis by the IDE.
donquixote added a commit to donquixote/rdf_entity that referenced this issue Dec 13, 2021
@donquixote
Github issue ec-europa#142: Replace deprecated drupal_get_path().
0f491ce
@donquixote donquixote mentioned this issue Dec 13, 2021
Closed
donquixote added a commit to donquixote/rdf_entity that referenced this issue Dec 13, 2021
@donquixote
Github issue ec-europa#142: Replace redundant continue; with comment.
cb1cf9f
donquixote added a commit to donquixote/rdf_entity that referenced this issue Dec 13, 2021
@donquixote
Github issue ec-europa#142: Use \Drupal::service() instead of \Drupal…
531090b 
…::getContainer()->get().

We are already not using dependency injection (normal in procedural code), so we can as well use the shortcut.
donquixote added a commit to donquixote/rdf_entity that referenced this issue Dec 13, 2021
@donquixote
Github issue ec-europa#142: Add inline doc on services.
24c7ec2 
This allows static analysis by the IDE.
donquixote added a commit to donquixote/rdf_entity that referenced this issue Dec 13, 2021
@donquixote
Github issue ec-europa#142: Replace deprecated drupal_get_path().
ceaae83
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor refactoring in rdf_entity_update_8004() donquixote/rdf_entity
1 participant
@donquixote