From cc41f57cbecfb23f1ebd1315114b1bfdaa20f6d4 Mon Sep 17 00:00:00 2001
From: Pirmin Mattmann <pimattmann@gmail.com>
Date: Tue, 15 Oct 2024 22:08:57 +0200
Subject: [PATCH 1/2] Allow delete ChecklistItem

---
 .../checklist/ChecklistItemEdit.vue           | 63 ++++++++++++++++++-
 frontend/src/locales/de.json                  |  1 +
 frontend/src/locales/en.json                  |  1 +
 3 files changed, 64 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/checklist/ChecklistItemEdit.vue b/frontend/src/components/checklist/ChecklistItemEdit.vue
index 4bf61d5488..651a038fc6 100644
--- a/frontend/src/components/checklist/ChecklistItemEdit.vue
+++ b/frontend/src/components/checklist/ChecklistItemEdit.vue
@@ -11,6 +11,30 @@
     submit-color="success"
     :cancel-action="close"
   >
+    <template #moreActions>
+      <PromptEntityDelete
+        :entity="checklistItem"
+        :submit-enabled="activitiesWithChecklistItem.length === 0"
+        align="left"
+        position="top"
+        :btn-attrs="{
+          class: 'v-btn--has-bg',
+        }"
+      >
+        <template v-if="activitiesWithChecklistItem.length > 0" #error>
+          <ErrorExistingActivitiesList
+            :camp="camp"
+            :existing-activities="activitiesWithChecklistItem"
+          />
+        </template>
+        {{
+          $tc('components.checklist.checklistItemEdit.delete', 0, {
+            text: checklistItem.text,
+          })
+        }}
+      </PromptEntityDelete>
+    </template>
+
     <template #activator="{ on }">
       <slot name="activator" v-bind="{ on }" />
     </template>
@@ -26,12 +50,19 @@
 </template>
 
 <script>
+import { sortBy } from 'lodash'
 import DetailPane from '@/components/generic/DetailPane.vue'
 import DialogBase from '@/components/dialog/DialogBase.vue'
+import PromptEntityDelete from '@/components/prompt/PromptEntityDelete.vue'
+import ErrorExistingActivitiesList from '@/components/campAdmin/ErrorExistingActivitiesList.vue'
 
 export default {
   name: 'ChecklistItemEdit',
-  components: { DetailPane },
+  components: {
+    DetailPane,
+    PromptEntityDelete,
+    ErrorExistingActivitiesList,
+  },
   extends: DialogBase,
   provide() {
     return {
@@ -48,6 +79,36 @@ export default {
       entityUri: '',
     }
   },
+  computed: {
+    camp() {
+      return this.checklist.camp()
+    },
+    activitiesWithChecklistItem() {
+      const activities = this.camp.activities().items
+      const allChecklistNodes = this.api
+        .get()
+        .checklistNodes({ camp: this.camp._meta.self }).items
+
+      const checklistNodes = allChecklistNodes.filter((cn) =>
+        cn.checklistItems().items.some((ci) => ci.id === this.checklistItem.id)
+      )
+
+      return sortBy(
+        activities.filter((a) =>
+          checklistNodes.some((cn) => cn.root().id === a.rootContentNode().id)
+        ),
+        (activity) =>
+          activity
+            .scheduleEntries()
+            .items.map(
+              (s) =>
+                `${s.dayNumber}`.padStart(3, '0') +
+                `${s.scheduleEntryNumber}`.padStart(3, '0')
+            )
+            .reduce((p, v) => (p < v ? p : v))
+      )
+    },
+  },
   watch: {
     showDialog: function (showDialog) {
       if (showDialog) {
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index b312d60140..fa0669c146 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -203,6 +203,7 @@
         "title": "Checklisteneintrag hinzufügen"
       },
       "checklistItemEdit": {
+        "delete": "Möchtest du diesen Eintrag wirklich löschen?",
         "title": "Checklisteneintrag bearbeiten"
       },
       "sortableChecklist": {
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index 4f28b3debb..81e655985f 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -202,6 +202,7 @@
         "title": "Add checklist entry"
       },
       "checklistItemEdit": {
+        "delete": "Do you really want to remove this item?",
         "title": "Edit checklist entry"
       },
       "sortableChecklist": {

From 4c6d66eaba2fdd6c2e07563656e1e5ecd55d1b6a Mon Sep 17 00:00:00 2001
From: Pirmin Mattmann <pimattmann@gmail.com>
Date: Tue, 15 Oct 2024 22:33:39 +0200
Subject: [PATCH 2/2] improve data-loading

---
 frontend/src/components/checklist/ChecklistItemEdit.vue | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/checklist/ChecklistItemEdit.vue b/frontend/src/components/checklist/ChecklistItemEdit.vue
index 651a038fc6..959c28683a 100644
--- a/frontend/src/components/checklist/ChecklistItemEdit.vue
+++ b/frontend/src/components/checklist/ChecklistItemEdit.vue
@@ -122,8 +122,11 @@ export default {
       }
     },
   },
-  mounted() {
+  async mounted() {
     this.api.href(this.api.get(), 'checklistItems').then((uri) => (this.entityUri = uri))
+
+    await this.api.get().checklistNodes({ camp: this.camp._meta.self })
+    await this.api.get().checklistItems({ 'checklist.camp': this.camp._meta.self })
   },
 }
 </script>