Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of "null" locale to symbolize Locale.ROOT #36

Open
claesrosell opened this issue Oct 21, 2023 · 0 comments
Open

Remove the usage of "null" locale to symbolize Locale.ROOT #36

claesrosell opened this issue Oct 21, 2023 · 0 comments

Comments

@claesrosell
Copy link
Contributor

claesrosell commented Oct 21, 2023

Issue #16 replaced the usage of UIUtils.ROOT with Locale.ROOT, however, it looks like "null" is used in various places of Babel Plugins to symbolize the ROOT locale. In some places used as key in maps. We may need a two step aproch where both values are allowed at first, like:

void someMethod(Locale locale) {
      Locale localeToUse = locale == null ? Locale.ROOT : locale;
      String value = this.hashMap.get(localeToUse);
      ...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant