Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown content-type with id: lng.cpp #224

Closed
EmergReanimator opened this issue Jan 6, 2024 · 11 comments · Fixed by #226
Closed

Unknown content-type with id: lng.cpp #224

EmergReanimator opened this issue Jan 6, 2024 · 11 comments · Fixed by #226
Milestone

Comments

@EmergReanimator
Copy link

Clang-17 seems to be incompatible with CDT-LSP 1.0.0.202309182153;

I observe following message in the error:
Plugin org.eclipse.cdt.lsp, extension org.eclipse.ui.editors: Unknown content-type with id: lng.cpp

@ghentschke
Copy link
Contributor

Could you please provide a Java stack trace?

@ghentschke
Copy link
Contributor

Wich CDT and Eclipse version do you use?

@EmergReanimator
Copy link
Author

EmergReanimator commented Jan 6, 2024

Wich CDT and Eclipse version do you use?

I tried several versions.
Eclipse 2023-12 (4.30.0), 2023-09 (4.29.0)
Eclipse CDT 11.4.0.202309142347, 11.3.0.202309051907

The same error is generated in both cases.

@EmergReanimator
Copy link
Author

Wich CDT and Eclipse version do you use?

Unfortunately I found no stack:
image

@ghentschke
Copy link
Contributor

ghentschke commented Jan 7, 2024

Thank you for the details! I've a few more questions to reproduce the error:

  1. Can you tell when it occurs? (During opening or editing a file? Which file ending has the file? -> important, since I think it has something to do with the file content type)
  2. What is not working as expected?

I don't think that it has something to do with the clang 17 compiler, since it's an editor issue in the cdt-lsp plugin.

@ghentschke
Copy link
Contributor

I think I found the reason. The cdt-lsp project depends on the TM4E project. lng.cpp is a content type definition for cpp files in org.eclipse.tm4e.language_pack/plugin.xml. This type has been renamed from lng.cpp to org.eclipse.tm4e.language_pack.cpp in this TM4E commit from 21. December 23.

I think we can remove the contentTypeBinding to lng.cpp in the org.eclipse.cdt.lsp/plugin.xml since TM4E issue has been fixed/closed

@ghentschke
Copy link
Contributor

Can you please tell me which tm4e version do you use?

@EmergReanimator
Copy link
Author

EmergReanimator commented Jan 7, 2024

Thank you for the details! I've a few more questions to reproduce the error:

1. Can you tell when it occurs? (During opening or editing a file? Which file ending has the file? -> important, since I think it has something to do with the file content type)

The issue happens immediately after start of the eclipse.

2. What is not working as expected?

No word completion and no content assist hints are shown.

I don't think that it has something to do with the clang 17 compiler, since it's an editor issue in the cdt-lsp plugin.

You are welcome to rename the issue accordingly.

@EmergReanimator
Copy link
Author

Can you please tell me which tm4e version do you use?

image

ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Jan 7, 2024
Since this eclipse-tm4e/tm4e#500 lsp4e issue has been
closed by this platform fix:
eclipse-platform/eclipse.platform#151 we can
now remove the contentTypeBinding to the lsp4e C++ content type
definition.

fixes eclipse-cdt#224
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Jan 7, 2024
Since this eclipse-tm4e/tm4e#500 lsp4e issue has been
closed by this platform fix:
eclipse-platform/eclipse.platform#151 we can
now remove the contentTypeBinding to the lsp4e C++ content type
definition.

fixes eclipse-cdt#224
@ghentschke ghentschke changed the title clang-17 support Unknown content-type with id: lng.cpp Jan 7, 2024
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Jan 7, 2024
Since this eclipse-tm4e/tm4e#500 lsp4e issue has been
closed by this platform fix:
eclipse-platform/eclipse.platform#151 we can
now remove the contentTypeBinding to the lsp4e C++ content type
definition.

fixes eclipse-cdt#224
@EmergReanimator
Copy link
Author

@ghentschke Did you realise the Git flow failure?: https://github.com/eclipse-cdt/cdt-lsp/actions/runs/7437200433

Invalid workflow file: .github/workflows/licensecheck.yml#L16
The workflow is not valid. .github/workflows/licensecheck.yml (Line: 16, Col: 3): Error calling workflow 'eclipse/dash-licenses/.github/workflows/mavenLicenseCheck.yml@master'. The nested job 'check-licenses' is requesting 'pull-requests: write', but is only allowed 'pull-requests: none'.

@ghentschke
Copy link
Contributor

ghentschke commented Jan 8, 2024

Did you realise the Git flow failure?: https://github.com/eclipse-cdt/cdt-lsp/actions/runs/7437200433

Yes, thank you. I've opened a PR for that.
Edit: I think that should be fixed now.

ghentschke added a commit that referenced this issue Jan 11, 2024
Since this eclipse-tm4e/tm4e#500 lsp4e issue has been
closed by this platform fix:
eclipse-platform/eclipse.platform#151 we can
now remove the contentTypeBinding to the lsp4e C++ content type
definition.

fixes #224
@ghentschke ghentschke added this to the 1.1.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants