Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make org.eclipse.cdt.lsp.clangd API public #242

Closed
ghentschke opened this issue Jan 30, 2024 · 4 comments
Closed

Make org.eclipse.cdt.lsp.clangd API public #242

ghentschke opened this issue Jan 30, 2024 · 4 comments

Comments

@ghentschke
Copy link
Contributor

Since some vendors using the API in the org.eclipse.cdt.lsp.clangd package we should tag it as public API.
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Jan 30, 2024
@ghentschke
[eclipse-cdt#242] make API of org.eclipse.cdt.lsp.clangd package public
914b354 
fixes eclipse-cdt#242
@ghentschke ghentschke mentioned this issue Jan 30, 2024
Closed
@ruspl-afed
Copy link
Member

  • -1 for LspPlugin - it shouldn't expose its UI Workbench nature to API
  • -1 for LspUtils - they should be internal or we should extract required functionality to dedicated types

@ghentschke
Copy link
Contributor Author

I am a little confused. LspPlugin and LspUtils are part of the org.eclipse.cdt.lsp package in the org.eclipse.cdt.lsp bundle.
I agree, LspPlugin and LspUtils need some rework, but this issue is about the org.eclipse.cdt.lsp.clangd package in the org.eclipse.cdt.lsp.clangd bundle. I cannot see, where the files in that package uses LspPlugin or LspUtils.

@ghentschke
Copy link
Contributor Author

Sorry, haven't seen that LspUtils and LspPlugin gets used in the org.eclipse.cdt.lsp.clangd package.

@ghentschke
Copy link
Contributor Author

Can be closed since #285 has been merged

ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Mar 5, 2024
@ghentschke
[eclipse-cdt#242] Make ClangdConfigurationFileManager public API
d006aee 
since its needed by some vendors to overwrite certain methods it should
be made available.
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Mar 5, 2024
@ghentschke
[eclipse-cdt#242] Make ClangdConfigurationFileManager public API
6ea2982 
since its needed by some vendors to overwrite certain methods it should
be made available.

part of eclipse-cdt#276
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Apr 30, 2024
@ghentschke
[eclipse-cdt#242] Make ClangdConfigurationFileManager public API
5c30041 
since its needed by some vendors to overwrite certain methods it should
be made available.

part of eclipse-cdt#276
ghentschke added a commit that referenced this issue Apr 30, 2024
@ghentschke
[#242] Make ClangdConfigurationFileManager configurable (#286)
eeb7fd7 
* [#242]  Add service to provide enabler to set database path in .clangd file

part of #276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#242] make API of org.eclipse.cdt.lsp.clangd package public ghentschke/eclipse-cdt-lsp
2 participants
@ruspl-afed @ghentschke