Initiate Negotiaition fails with error: Policy in the contract agreement is not equal to the one in the contract offer

[hemantxpatel]

Description

I am trying to initiate a negotiation but it fails with error message.

Service call failed: Contract agreement received. Validation failed: Policy in the contract agreement is not equal to the one in the contract offer

How to Reproduce

Step 1: Create Policy

curl --location 'http://localhost/alice/management/v2/policydefinitions' \
--header 'Content-Type: application/json' \
--header 'X-Api-Key: password' \
--data-raw '{
    "@context": {
        "odrl": "http://www.w3.org/ns/odrl/2/"
    },
    "@type": "PolicyDefinitionRequestDto",
    "@id": "1",
    "policy": {
		"@type": "odrl:Set",
		"odrl:permission" : [{
			"odrl:action" : "USE",
			"odrl:constraint" : {
				"@type": "LogicalConstraint",
				"odrl:or" : [{
					"@type" : "Constraint",
					"odrl:leftOperand" : "https://w3id.org/tractusx/v0.0.1/ns/BusinessPartnerGroup",
					"odrl:operator" : {
                        "@id": "odrl:eq"
                    },
					"odrl:rightOperand" : "gold-partners"
				}]
			}
		}]
    }
}'

Step 2: Query Catalog

It works fine and returns the target assets.

Step 3: Initiate Negotiation

curl --location 'http://localhost/bob/management/v2/contractnegotiations' \
--header 'Content-Type: application/json' \
--header 'X-Api-Key: password' \
--data-raw '{
	"@context": {
		"odrl": "http://www.w3.org/ns/odrl/2/"
	},
	"@type": "NegotiationInitiateRequestDto",
	"connectorAddress": "http://alice-controlplane:8084/api/v1/dsp",
	"protocol": "dataspace-protocol-http",
	"connectorId": "BPNL000000000001",
	"providerId": "BPNL000000000001",
	"offer": {
		"offerId": "MQ==:MQ==:ZjY3MzRjMzktNDg5Zi00YjNjLTljMTQtOTEyNzQ4MzllOGMy",
		"assetId": "1",
		"policy": {
			"@type": "odrl:Set",
			"odrl:permission": {
				"odrl:target": "1",
				"odrl:action": {
					"odrl:type": "USE"
				},
				"odrl:constraint": {
            "odrl:or": {
              "odrl:leftOperand": "https://w3id.org/tractusx/v0.0.1/ns/BusinessPartnerGroup",
              "odrl:operator": {
                "@id": "odrl:eq"
              },
              "odrl:rightOperand": "gold-partners"
            }
          }
			},
			"odrl:prohibition": [],
			"odrl:obligation": [],
			"odrl:target": "1"
		}
	}
}'

Check Consumer Connector logs

DEBUG 2024-02-20T11:51:13.384039505 [ConsumerContractNegotiationManagerImpl] ContractNegotiation 8d872780-6ec9-4078-b057-861bfea6c89e is now in state INITIAL
DEBUG 2024-02-20T11:51:13.605634639 [ConsumerContractNegotiationManagerImpl] ContractNegotiation 8d872780-6ec9-4078-b057-861bfea6c89e is now in state REQUESTING
DEBUG 2024-02-20T11:51:13.615192938 ContractNegotiation: ID 8d872780-6ec9-4078-b057-861bfea6c89e. [Consumer] send request
DEBUG 2024-02-20T11:51:19.247289995 ContractNegotiation: ID 8d872780-6ec9-4078-b057-861bfea6c89e. [Consumer] send request
DEBUG 2024-02-20T11:51:19.255111993 [ConsumerContractNegotiationManagerImpl] ContractNegotiation 8d872780-6ec9-4078-b057-861bfea6c89e is now in state REQUESTED
DEBUG 2024-02-20T11:51:19.857537903 DSP: Incoming ContractAgreementMessage for class org.eclipse.edc.connector.contract.spi.types.negotiation.ContractNegotiation process: 8d872780-6ec9-4078-b057-861bfea6c89e
DEBUG 2024-02-20T11:51:20.170684912 [Consumer] Contract agreement received. Validation failed: Policy in the contract agreement is not equal to the one in the contract offer
DEBUG 2024-02-20T11:51:20.176246586 DSP: Service call failed: Contract agreement received. Validation failed: Policy in the contract agreement is not equal to the one in the contract offer

Why it fails

Policy in contract agreement doesn't match with policy in contract negotiation.

Connector/core/control-plane/contract-core/src/main/java/org/eclipse/edc/connector/contract/validation/ContractValidationServiceImpl.java

Lines 116 to 118 in b53192f

	if (!policyEquality.test(agreement.getPolicy().withTarget(latestOffer.getAssetId()), latestOffer.getPolicy())) {
	return failure("Policy in the contract agreement is not equal to the one in the contract offer");
	}

I found policy#permission#target was null in agreement but it was 1 (target asset Id) in contract negotiation.

Temporary Workaround

While initiating negotiation, pass policy#permissions#target as null and hence it matches with the agreement policy. Transfer works successfully, but not sure about the implications.

Possible Fix

policy#target is copied from contract negotiation policy to agreement policy before policy is compared.

if (!policyEquality.test(agreement.getPolicy().withTarget(latestOffer.getAssetId()), latestOffer.getPolicy())) { ... }

Copy policy#permission#target as well from contract negotiation policy to agreement policy.

[hemantxpatel]

@ndr-brt Could you please have a look.

[ndr-brt]

please be aware that the offer property has been deprecated, you should switch to policy (that will contain only the odrl representation of the contract offer, as @wolf4ood stated, it should the target only at the root level )

[hemantxpatel]

Thanks, Raised an issue to update it. eclipse-tractusx/tutorial-resources#249

[wolf4ood]

hi @hemantxpatel afaik the target will be removed on specific rule and should only exists on root level

#3872

[hemantxpatel]

Awesome, thanks for confirming. Will remove target at permission level from MXD.