Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loop in MultiViewHandler.normalizeRequestURI #5525

Open
pdudits opened this issue Nov 5, 2024 · 0 comments · May be fixed by #5526
Open

Endless loop in MultiViewHandler.normalizeRequestURI #5525

pdudits opened this issue Nov 5, 2024 · 0 comments · May be fixed by #5526

Comments

@pdudits
Copy link

pdudits commented Nov 5, 2024

Describe the bug

When FacesServlet is mapped to /* or invoked via forwarding where other servlet has this mapping, the view processing never terminates as it is stuck in while loop in MultiViewHandler.normalizeRequestURI. mapping is "" in this case and therefore loop condition is always true and the viewId never changes.

To Reproduce

Steps to reproduce the behavior:

  1. Set mapping of facesServlet to /*
  2. Make a request to a view
  3. Observe infinite loop

Expected behavior

Request processing should terminate. Given that /* is rare but valid entry, it shouldn't try any normalization

Additional context

Will provide PR for version 4, master is not buildable at this time.

@pdudits pdudits linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant