BasicLocationTests#testCreateLocation04() fails silently

[HeikoKlare]

The test case org.eclipse.osgi.tests.services.datalocation.BasicLocationTests#testCreateLocation04() fails silently. The test runs into a fail statement, which is caught and ignored by a surrounding try-catch:

equinox/bundles/org.eclipse.osgi.tests/src/org/eclipse/osgi/tests/services/datalocation/BasicLocationTests.java

Lines 149 to 155 in 60a2e63

	try {
	testLocation.set(testLocationFile.toURL(), true);
	testLocation.release();
	fail("Should not be able to lock read-only location");
	} catch (Throwable t) {
	// expected
	}

I tried to replace this block with an assertThrows in #455, which fails because nothing is actually thrown.

I have not yet investigated whether the test or the tested functionality is faulty.

[github-actions]

This issue has been inactive for 180 days and is therefore labeled as stale.
If this issue became irrelevant in the meantime please close it as completed. If it is still relevant and you think it should be fixed some possibilities are listed below.
Please read https://github.com/eclipse-equinox/.github/blob/main/CONTRIBUTING.md#contributing-to-eclipse-equinox for ways to influence development.

[tjwatson]

Apologize for the slow response, I must have missed this issue being open over the Holidays. The test is indeed bogus and if properly written it would have caught a regression introduced by eclipse-equinox/equinox.framework#39