-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASTConverterSuperAfterStatements.test004 fails on master #2187
Comments
Code generated for the constructor is
In the call stack below, we compute the
In short I think the warning is good and is pointing to a problem in the product. |
In this call stack below codeStream.stackDepth becomes -1 which is illegal.
|
Manoj, please follow up. Stack traces above point to the problem spots. |
Sure Srikanth.. let me take a look |
I suggest you disable the test by prefixing with _ and merge a commit to master - otherwise we are going to see a failing tests on all PRs until this is resolved. Thanks. Not just jdt/core others will see this failure too and may be puzzled: see #2194 |
Found you! To check why my PR build failed I incrementally merged commits from master into BETA_JAVA22. It was when I merged #2171 that this test started to fail. Looks like this is old news for you guys :) On the way I was puzzled about the relation between BETA_JAVA22 and #2181: Neither EGit nor github seems to show any relation although reportedly the branch was merged, Egit shows it as if the entire branch BETA_JAVA22 was squashed into a single commit?? |
@jarthana could you answer this question please ? Thanks. |
Never mind, my EGit history view had "Show first parent only" enabled (don't know why). Disabling that option revealed the missing link: Sorry for the noise. |
Yes please. All PR builds are failing due to this for more than 4 days now. |
Hello! After this fix, I get an AssertionError here:
|
Please ignore. Dirty workspace ... Sorry about the noise. |
@srikanth-sankaran |
* fixes eclipse-jdt#2181 * Fixing the tests
* fixes eclipse-jdt#2181 * Fixing the tests
Seems to trigger the new warning:
The text was updated successfully, but these errors were encountered: