Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline method operation drops NLS tags #1856

Open
srikanth-sankaran opened this issue Dec 16, 2024 · 0 comments
Open

Inline method operation drops NLS tags #1856

srikanth-sankaran opened this issue Dec 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@srikanth-sankaran
Copy link

I have a method like this:

			private char[] typeSwitchSignature(TypeBinding exprType) {
				return CharOperation.concat("(".toCharArray(), exprType.erasure().signature(), "I)I".toCharArray()); //$NON-NLS-1$ //$NON-NLS-2$
			}

and the sole call site looks like this: char[] signature = typeSwitchSignature(selectorType);

If I perform the inline method refactoring, I end up with:

char[] signature = CharOperation.concat("(".toCharArray(), selectorType.erasure().signature(), "I)I".toCharArray());

and two warnings: `Non-externalized string literal; it should be followed by //$NON-NLS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants