Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of __THROW in omrsig.h/cpp extern C code #7643

Open
Deigue opened this issue Feb 5, 2025 · 0 comments
Open

Usage of __THROW in omrsig.h/cpp extern C code #7643

Deigue opened this issue Feb 5, 2025 · 0 comments

Comments

@Deigue
Copy link
Contributor

Deigue commented Feb 5, 2025

Wanted to create an issue to separate out the problem raised during review of #7320

Not directly related to the changed being made, but a cause for concern here in https://github.com/eclipse-omr/omr/blob/master/include_core/omrsig.h , are the uses of __THROW seemingly within extern C code,

Their usages also corresponding in https://github.com/eclipse-omr/omr/blob/master/omrsigcompat/omrsig.cpp as result could be invalid.

Further there is also #7320 (comment) , referring to

extern "C" {
. The need for the definition of sighandler itself to be within extern C.

I had an initial attempt at removing these but was facing errors/issues after having undone the macro definitions/usages.

Creating this issue to piece this out and investigate separately and try to get the original PR #7320 merged asap, as it has been open for a long period and is critical for the Open XL build enablement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant