Do not create a Pull Request without creating an issue first
The design of your solution to the problem should be discussed and agreed in an issue before submitting the PR
ECA - Eclipse Contributer Agreement
Ensure you have a valid, signed ECA for the email address associated with your Github account (or you sign off your PR with an ECA'd address)
Please provide enough information so that others can review your pull request:
Testing
Any code changes should have accompanying tests.
Closing issues
Put closes #XXXX
in your comment to auto-close the issue that your PR fixes.