Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublishWithOptions() will not return ErrInvalidArguments when QoS is invalid #232

Closed
vishnureddy17 opened this issue Jan 29, 2024 · 3 comments · Fixed by #235
Closed

PublishWithOptions() will not return ErrInvalidArguments when QoS is invalid #232

vishnureddy17 opened this issue Jan 29, 2024 · 3 comments · Fixed by #235

Comments

@vishnureddy17
Copy link
Contributor

https://github.com/eclipse/paho.golang/blob/ef0065fea247d5fb388fa82390cedce694e844e1/paho/client.go#L885

This should have ErrInvalidArguments in its tree so the application knows it is a fatal error. This is a very quick fix and I am happy to open a PR for it.
@MattBrittan
Copy link
Contributor

This is a very quick fix and I am happy to open a PR for it.

Please do - keen to get a release out this week and would be nice to have this fixed.

@vishnureddy17
Copy link
Contributor Author

Will open a PR today or tomorrow (US Eastern time). Would you like me to incorporate a fix to #233 as well? @MattBrittan

@MattBrittan
Copy link
Contributor

Would you like me to incorporate a fix to #233 as well

Yes please.

@vishnureddy17 vishnureddy17 mentioned this issue Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vishnureddy17 @MattBrittan