Adding SWT + JFace when creating a plugin that "makes contribution to the UI" #1306
Comments
|
Currently this flag is only used to select the templates. I would dislike having plug-in dependencies automatically added. Maybe you can better provide a JFace and SWT template in the template section if that flag is set? |
It marks this plugin as a singelton also
Why?
It seems odd to require an additional step, beside that what should such "template" offer? |
Because I may want to make a menu contribution via model elements and in this case I do not need SWT and JFace. |
That's what I mean with "and easy to remove in rare cases where it is not desired", having only a menu contribution without defining any handler that do not reference anything (e.g. shells, dialogs, ...) is likely seldom. And even in that case there is a high chance one later adds new features to the plugin that still require SWT/JFace. |
|
Its is also easy to add dependencies, if you need it. -1 from me for such adjustments. |
No one questions it, but if I have two "easy" options and I need |
|
You could add a template for your 99% use case. |
|
@laeubi if you want this, please ask a PDE project lead to resolve our conflict. |
Using a template is simply over engineered here and more complex, first it needs another step, then I need to find it (not to mention that I need to know about this). Also it is simply bad UX if I need to take action for the most common usecase ... from my point of view real problem of Eclipse IDE is not darkmode, startup times or fancy new feature, the main problem is that we make it extremely hard for users to perform their (common) task because we hide everything behind options multi-page wizards and insider knowledge ... |
Although I'm not sure if the numbers are that clear (in fact I can only guess from my own experience), I also assume that in the majority of cases where that option is enabled one also uses SWT/Jface.
If that option is without effect if no template is selected, would it then be a solution to only add these dependencies if no template is selected later? If one doesn't want those dependencies then one should simply not check this box. The existing templates are then not changed. IIRC that option also has an effect if an activator is generated, which then extends |
|
Strange behaviour, I saw my comment twice now both are gone.... To repeat: if @HannesWell is fine with the proposal to add SWT and jface if the UI flag is set that is fine for me. |
I got one mail for the previous comment (which is also gone for me) and this one.
Great. Assuming everything is as I described in my last post, I don't see a real drawback. |
|
The 'Make contribution to UI' choice does the following things :
That was the default behavior for Eclipse 3 ui Plugins. With Eclipse 4 we have different behaviors. We can :
If we give the choice between E3, E3-E4, E4, we will show that different UI concerns can be managed, and we will be able to filter the the templates choice in the next page (even for the templates proposed if we choose 'create a RCP application')... So this current issue is may be to specific and should be considered in a more general way, this is why I opened the issue #1378 (that was already opened on the bugzilla in 2018 but automatically closed yesterday...)... |
|
By the way in the previous Wizard ask what OSGi framework is to be used, maybe instead of "make contributon to the ui" would be having a drowdown with options:
|
Currently if one creates a new plugin project and chooses in the wizard
One of the first things I usually then do is adding swt + jface as required bundles, because otherwise it is hard to really "contribute to the UI".
As these are dependencies of any Eclipse IDE anyways and easy to remove in rare cases where it is not desired, I like to suggest we simply add them by default.
The text was updated successfully, but these errors were encountered: