Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E4 Editor is not able to discover references from dynamic model contributions #1307

Open
laeubi opened this issue Jun 18, 2024 · 4 comments
Open

Comments

@laeubi
Copy link
Contributor

laeubi commented Jun 18, 2024

I really like using the dynamic model registration but found one problem today, the E4 editor seem not be able to discover such contributions (FYI @fipro78)

  1. have one model extension that defines a part and uses plugin.xml
  2. have one model extension that defines a part and uses MANIFEST.MF
  3. Now create a new model extension and go to the imports, add a new part
  4. In the search dialog now the part from the plugin.xml defining one is found, the one from MANIFEST.MF is not
@opcoach
Copy link
Contributor

opcoach commented Sep 25, 2024

Hi Christoph, could you join your sample project to check it ?

@laeubi
Copy link
Contributor Author

laeubi commented Sep 25, 2024

@opcoach You can easily create just some random bundles as described above, let me know if any step is unclear. If you create a new fragment the wizard will be asked if you want the dynamic way or the static way (using plugin.xml) thats it:

grafik

@opcoach
Copy link
Contributor

opcoach commented Sep 27, 2024

About the 'find' button in model editor dialog, nothing is really found anyway and not only in the import section of the editor... This issue should consider to review all the find mechanisms in the editor...

For instance, if you create another model fragment with some MPlaceHolder, you should be able to bind it to an existing E3 view (accessible with a dependency to the E3 plugin) ro to any partDescriptorsIDs (whatever their source definition (dynamic or static..)...

Or if your plugin depends on org.eclipse.ui and you create a model fragment with an import of a command... you should see all the command IDs provided by org.eclipse.ui... that would be the case where your model fragment will provide an additional handler for a low level command (like org.eclipse.ui.edit.copy)...

Actually there is not index in E4 that contains all the objects accessible depending on their types.. or if there is one, it is not updated when new fragments or dependencies are added or changed...

So may be this issue should be closed and reopened in a more general issue : 'Fix the find mechanism in the model editors".

There is also a label mistake in the dialog : should be named 'New Application fragment model'...

@laeubi
Copy link
Contributor Author

laeubi commented Sep 27, 2024

As said when I define it in plugin.xml the search works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants