-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local SDK build on tag I20240314-1800
fails
#1911
Comments
@laeubi , @HannesWell : any idea why local SDK build would fail now with this error? I always run SDK build on Friday locally that is used for internal product tests to find regressions on master. |
@iloveeclipse Based on my past experience I can say this is a comparator problem. Comparator has replaced newly built org.eclipse.swt with one from 4.32-I-builds repository. Here are my observations I think the root cause in the calculation of git timestamp. You are getting 20240313-1127 instead of 20240313-1227. Based on the 1 hour in time stamp difference I am guessing this may be caused by DST change at the start of this week. As far as I remember the qualifier used to be calculated based on UTC timestamp. I may be worth investigating why the DST is being taken into account now. The qualifier calculation is done in tycho plugin |
More information The commit used for calculating qualifier is eclipse-platform/eclipse.platform.swt@9f206d8. |
@sravanlakkimsetti : many thanks! I haven't noticed 1 hour version difference at all!
@HannesWell, @laeubi : could you please check whether tycho or SWT should be fixed here?
See here, I was running this build in Germany where DST change not happened yet:
|
As far as I know JGit is used here where the commit time is used I can't see we have any influence on the timezone there and it should be GMT based, at least I don't see how Tycho can influence it: then it uses a datetimeformat: and internally we force that to use UTC as well: |
OK, so that below is what tycho does?
I've quickly checked |
The message is printed when the mojo is executed: If you have a failing build you can run it with |
Could it be, https://github.com/eclipse-tycho/tycho/blob/d6366adf73b9028fb192a550e4bef2950700791a/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/buildversion/FragmentHostBuildTimestampProvider.java#L78 needs something like |
I think its worth a try. |
Could you try to do so? I simply don't have enough time / experience to build & debug Tycho & use SDK with that debug build. |
Yes I'll take a look later on, just in case here is the simple way to build test:
|
Seem to work.
|
@laeubi : could you please apply patch to tycho & deploy 4.0.7 snapshot, so SDK build could use it? |
It is already on the train: |
Perfect, thanks. |
What is the status here? |
Just built one without patching anything. |
My local SDK build on tag
I20240314-1800
fails (tried two times with maven 3.9.2 / 3.9.6).Last successful build was last Friday at tag
I20240307-1800
.It seems something is wrong either with SWT or with
org.eclipse.equinox.p2.tests
but I don't see why should it work on master and not on my local build (which is essentially same but just in a different environment).This seem to be the root cause:
So it seems SWT Linux fragment can't be found matching SWT version. I don't understand why, the fragment seem to be built:
Here the end of the maven log:
The text was updated successfully, but these errors were encountered: