Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing org.eclipse.core.tests.internal.preferences.PreferencesServiceTest#testLookupOrder #1087

Closed
HeikoKlare opened this issue Jan 11, 2024 · 0 comments · Fixed by #1088
Closed

Failing org.eclipse.core.tests.internal.preferences.PreferencesServiceTest#testLookupOrder #1087

HeikoKlare opened this issue Jan 11, 2024 · 0 comments · Fixed by #1088
Labels
test junit test related things

Comments

@HeikoKlare
Copy link
Contributor

org.eclipse.core.tests.internal.preferences.PreferencesServiceTest#testLookupOrder() is failing, probably because of the user scope recently added in Equinox: eclipse-equinox/equinox#446

See for example: https://github.com/eclipse-platform/eclipse.platform/actions/runs/7492737383/job/20398029585

1.2: array lengths differed, expected.length=4 actual.length=5; arrays first differed at element [3]; expected:<[default]> but was:<[user]>
	at org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:78)
	at org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:28)
	at org.junit.Assert.internalArrayEquals(Assert.java:534)
	at org.junit.Assert.assertArrayEquals(Assert.java:285)
	at org.eclipse.core.tests.internal.preferences.PreferencesServiceTest.testLookupOrder(PreferencesServiceTest.java:237)
@HeikoKlare HeikoKlare added bug Something isn't working test junit test related things and removed bug Something isn't working labels Jan 11, 2024
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Jan 11, 2024
@HeikoKlare
Adapt PreferencesServiceTest#testLookupOrder() to UserScope eclipse-p…
055326e 
…latform#1087

Adapts the test case PreferencesServiceTest#testLookupOrder() to reflect
the UserScope added to Equinox. Also improves the assertions in the test
case.

Fixes eclipse-platform#1087
@HeikoKlare HeikoKlare mentioned this issue Jan 11, 2024
Merged
HeikoKlare added a commit that referenced this issue Jan 12, 2024
@HeikoKlare
Adapt PreferencesServiceTest#testLookupOrder() to UserScope #1087
db25c86 
Adapts the test case PreferencesServiceTest#testLookupOrder() to reflect
the UserScope added to Equinox. Also improves the assertions in the test
case.

Fixes #1087
raghucssit pushed a commit to raghucssit/eclipse.platform that referenced this issue Jan 15, 2024
@HeikoKlare @raghucssit
Adapt PreferencesServiceTest#testLookupOrder() to UserScope eclipse-p…
0984bc7 
…latform#1087

Adapts the test case PreferencesServiceTest#testLookupOrder() to reflect
the UserScope added to Equinox. Also improves the assertions in the test
case.

Fixes eclipse-platform#1087
Michael5601 pushed a commit to CodeLtDave/eclipse.platform that referenced this issue Feb 12, 2024
@HeikoKlare @Michael5601
Adapt PreferencesServiceTest#testLookupOrder() to UserScope eclipse-p…
a4c1572 
…latform#1087

Adapts the test case PreferencesServiceTest#testLookupOrder() to reflect
the UserScope added to Equinox. Also improves the assertions in the test
case.

Fixes eclipse-platform#1087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test junit test related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt PreferencesServiceTest#testLookupOrder() to UserScope #1087 HeikoKlare/eclipse.platform
1 participant
@HeikoKlare