Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS/Dash: Print license check problems into PRs #347

Closed
AlexanderLanin opened this issue Feb 12, 2025 · 2 comments · Fixed by #378
Closed

OSS/Dash: Print license check problems into PRs #347

AlexanderLanin opened this issue Feb 12, 2025 · 2 comments · Fixed by #378
Assignees
@dcalavrezo-qorix

Comments

@AlexanderLanin
Copy link
Member

The "license check preparation" job (see #155) runs in the background and the output is invisible. We don't want to make it blocking (red), since we know that it will "fail" frequently.

Task: print the output of dash tool as a readable comment into PRs.

Hint: See docs.yml for an action we are already using to write comments.
@AlexanderLanin AlexanderLanin mentioned this issue Feb 12, 2025
Open
@AlexanderLanin AlexanderLanin changed the title Print license check problems into PRs OSS/Dash: Print license check problems into PRs Feb 12, 2025
@dcalavrezo-qorix dcalavrezo-qorix self-assigned this Feb 12, 2025
@dcalavrezo-qorix dcalavrezo-qorix moved this from Todo to In Progress in Operational (Tooling/Infrastructure) Feb 13, 2025
@dcalavrezo-qorix
Copy link
Contributor

@AlexanderLanin but #155 doesn't seem to have been merged yet. Is it something that is blocking it?

@dcalavrezo-qorix dcalavrezo-qorix moved this from In Progress to Blocked in Operational (Tooling/Infrastructure) Feb 13, 2025
@dcalavrezo-qorix
Copy link
Contributor

marked is as blocked till #155 is merged

dcalavrezo-qorix added a commit to qorix-group/score that referenced this issue Feb 14, 2025
@dcalavrezo-qorix
license: adapt workflow
943ef05 
The license check preparation workflow - which basically executed dash within bazel
won't stop on failure.
It will display the outcome to the PR in form of a comment

Fixes eclipse-score#347 eclipse-score#126

Signed-off-by: Dan Calavrezo <[email protected]>
dcalavrezo-qorix added a commit to qorix-group/score that referenced this issue Feb 14, 2025
@dcalavrezo-qorix
dash: license check integration
d2f5225 
picked-up PR#155

This PR adds support for the DASH tool within the S-CORE Bazel build system. The integration includes:

Defining custom Bazel rules to handle the DASH tool's setup and execution.
Adding necessary dependencies in BUILD files to ensure compatibility with existing project requirements.
Validating the integration with the current CI pipeline to maintain a seamless build and deployment process.
This enhancement simplifies the workflow by consolidating tools into the Bazel build system, improving build automation and traceability.

The license check preparation workflow - which basically executed dash within bazel
won't stop on failure.
It will display the outcome to the PR in form of a comment

Fixes eclipse-score#347 eclipse-score#126

Signed-off-by: Dan Calavrezo <[email protected]>
dcalavrezo-qorix added a commit to qorix-group/score that referenced this issue Feb 14, 2025
@dcalavrezo-qorix
dash: license check integration
2b8b9e4 
picked-up PR#155

This PR adds support for the DASH tool within the S-CORE Bazel build system. The integration includes:

Defining custom Bazel rules to handle the DASH tool's setup and execution.
Adding necessary dependencies in BUILD files to ensure compatibility with existing project requirements.
Validating the integration with the current CI pipeline to maintain a seamless build and deployment process.
This enhancement simplifies the workflow by consolidating tools into the Bazel build system, improving build automation and traceability.

The license check preparation workflow - which basically executed dash within bazel
won't stop on failure.
It will display the outcome to the PR in form of a comment

Fixes eclipse-score#347 eclipse-score#126

Signed-off-by: Dan Calavrezo <[email protected]>
@dcalavrezo-qorix dcalavrezo-qorix mentioned this issue Feb 14, 2025
Merged
@dcalavrezo-qorix dcalavrezo-qorix moved this from Blocked to In Progress in Operational (Tooling/Infrastructure) Feb 14, 2025
AlexanderLanin pushed a commit that referenced this issue Feb 18, 2025
@dcalavrezo-qorix @nradakovic
dash: integration (#378)
9c05877 
Add support for the DASH tool within the S-CORE Bazel build system.
The integration includes:

- Defining custom Bazel rules to handle the DASH tool's setup and execution.
- Adding necessary dependencies in BUILD files to ensure compatibility with
  existing project requirements.
- Validating the integration with the current CI pipeline to maintain a seamless build
  and deployment process.
- Updating documentation (if applicable) to reflect the addition of DASH
  in the Bazel workflow.

This enhancement simplifies the workflow by consolidating tools into the Bazel build system,
improving build automation and traceability.

Issue-ref: see #126

The license check preparation workflow - which basically executed dash within bazel
won't stop on failure.
It will display the outcome to the PR in form of a comment

Fixes #347 #126

Signed-off-by: Dan Calavrezo <[email protected]>
Co-authored-by: Nikola Radakovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcalavrezo-qorix dcalavrezo-qorix

Labels
None yet
Projects
Operational (Tooling/Infrastructure)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dash: integration qorix-group/score
2 participants
@AlexanderLanin @dcalavrezo-qorix