Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential NPE in GsonEObjectDeserializer#resolveType #50

Open
AxelRICHARD opened this issue Sep 25, 2024 · 0 comments · May be fixed by #51
Open

Potential NPE in GsonEObjectDeserializer#resolveType #50

AxelRICHARD opened this issue Sep 25, 2024 · 0 comments · May be fixed by #51
Assignees
@AxelRICHARD

Comments

@AxelRICHARD
Copy link

In https://github.com/eclipse-sirius/sirius-emf-json/blob/master/bundles/org.eclipse.sirius.emfjson/src/main/java/org/eclipse/sirius/emfjson/utils/GsonEObjectDeserializer.java#L619, this.resourceSet.getPackageRegistry() is called without check on this.resourceSet, which can raise NPE.
Furthermore, in https://github.com/eclipse-sirius/sirius-emf-json/blob/master/bundles/org.eclipse.sirius.emfjson/src/main/java/org/eclipse/sirius/emfjson/utils/GsonEObjectDeserializer.java#L174, a variable this.packageRegistry already contains the appropriate value.

So, it seems that this.resourceSet.getPackageRegistry() should be replaced by this.packageRegistry in GsonEObjectDeserializer
@AxelRICHARD AxelRICHARD added bug Something isn't working and removed bug Something isn't working labels Sep 25, 2024
@AxelRICHARD AxelRICHARD self-assigned this Sep 25, 2024
AxelRICHARD added a commit that referenced this issue Sep 26, 2024
@AxelRICHARD
[50] Fix potential NPE in GsonEObjectDeserializer#resolveType
524160c 
Bug: #50
Signed-off-by: Axel RICHARD <[email protected]>
@AxelRICHARD AxelRICHARD linked a pull request Sep 26, 2024 that will close this issue
Open
@AxelRICHARD AxelRICHARD linked a pull request Sep 26, 2024 that will close this issue
[50] Fix potential NPE in GsonEObjectDeserializer#resolveType #51
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[50] Fix potential NPE in GsonEObjectDeserializer#resolveType eclipse-sirius/sirius-emf-json
1 participant
@AxelRICHARD