Skip to content

Commit

Permalink
bumped version of 'yeoman-generator' to ^7.0.0
Browse files Browse the repository at this point in the history
* upgraded the dependency of 'yeoman-test' already to '^8.0.0' because of a problematic dependency in '^7.0.0' ([email protected]...', has been by '[email protected]...')
* added a 'resolution' on '[email protected]', as that dependency is only referenced as peer-dependency by all up-to-date versions of using packages - which are not installed by yarn (in contrast to npm) -, but it's required at runtime; filed a request on Github to add '[email protected]' as a prod dependency to 'yeoman-generator': yeoman/generator#1495; besides '[email protected]' insists on 'mem-fs-editor@^10.0.3' (which depends on 'mem-fs@^3.0.0'), both declare "acceptDependencies" { "mem-fs": "^4.0.0" } - which again is not considered by yarn

Signed-off-by: Christian Schneider <[email protected]>
  • Loading branch information
sailingKieler committed Jan 17, 2024
1 parent 0fdbc30 commit 6659779
Show file tree
Hide file tree
Showing 4 changed files with 1,096 additions and 1,272 deletions.
13 changes: 12 additions & 1 deletion .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,21 @@
"theia-extension"
],
"cwd": "${workspaceFolder}/testing",
"console": "integratedTerminal",
"console": "integratedTerminal",
"skipFiles": [
"<node_internals>/**"
],
},
{
"name": "Run tests via YARN",
"request": "launch",
"nodeVersionHint": 18,
"runtimeExecutable": "yarn",
"args": [ "test" ],
"skipFiles": [
"<node_internals>/**"
],
"type": "node"
}
]
}
9 changes: 6 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"dependencies": {
"request": "^2.88.2",
"tar": "^6.1.1",
"yeoman-generator": "^6.0.0"
"yeoman-generator": "^7.0.0"
},
"devDependencies": {
"@types/request": "^2.48.0",
Expand All @@ -33,8 +33,11 @@
"rimraf": "^3.0.0",
"typescript": "~4.7.0",
"yeoman-assert": "^3.1.1",
"yeoman-environment": "^3.0.0",
"yeoman-test": "^6.0.0"
"yeoman-environment": "^4.0.0",
"yeoman-test": "^8.0.0"
},
"resolutions": {
"mem-fs": "^4.0.0"
},
"files": [
"generators",
Expand Down
2 changes: 1 addition & 1 deletion test/generator-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('test extension generation', function () {
it('generate the hello world extension', function (done) {
const name = 'hello-world-test';
helpers.run(path.join(__dirname, '../generators/app'))
.withPrompts({
.withAnswers({
type: 'hello-world',
name
})
Expand Down
Loading

0 comments on commit 6659779

Please sign in to comment.