-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted generator into an ESM package, bumped yeoman-generator dependency to vision ^7.0.0 #188
base: master
Are you sure you want to change the base?
Converted generator into an ESM package, bumped yeoman-generator dependency to vision ^7.0.0 #188
Conversation
6849175
to
c44e654
Compare
ef0d095
to
563f11f
Compare
As indicated by the original title, I've prepared another change bumping to |
…erator to ^6.0.0 bumped typescript version to ~4.7.0 to be able to * set tsConfig options 'module' and 'moduleResolution' to value of 'Node16', see https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html * deal with the transitive dependency 'mem-fs-editor' in version 10.0.x containing function alias assignments including type argument assignments, see https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#instantiation-expressions Signed-off-by: Christian Schneider <[email protected]>
563f11f
to
6659779
Compare
Since the ci build is now using Node18 (#193) I updated this branch and added my additional commit bumping the dependency of |
* upgraded the dependency of 'yeoman-test' already to '^8.0.0' because of a problematic dependency in '^7.0.0' ([email protected]...', has been by '[email protected]...') * added a 'resolution' on '[email protected]', as that dependency is only referenced as peer-dependency by all up-to-date versions of using packages - which are not installed by yarn (in contrast to npm) -, but it's required at runtime; filed a request on Github to add '[email protected]' as a prod dependency to 'yeoman-generator': yeoman/generator#1495; besides '[email protected]' insists on 'mem-fs-editor@^10.0.3' (which depends on 'mem-fs@^3.0.0'), both declare "acceptDependencies" { "mem-fs": "^4.0.0" } - which again is not considered by yarn Signed-off-by: Christian Schneider <[email protected]>
6659779
to
99b4555
Compare
Cool, just to make sure: have you tested all templates whether they work as expected? |
As announced in the dev meeting yesterday - and although I don't see any urgency to merge it ASAP - here's my additional work on the generator:
converted generator into an ESM package, bumped version of yeoman-generator to ^6.0.0
bumped version of 'yeoman-generator' to ^7.0.0
besides '[email protected]' insists on 'mem-fs-editor@^10.0.3' (which depends on 'mem-fs@^3.0.0'), both declare "acceptDependencies" { "mem-fs": "^4.0.0" } - which again is not considered by yarn