Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted generator into an ESM package, bumped yeoman-generator dependency to vision ^7.0.0 #188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sailingKieler
Copy link
Contributor

@sailingKieler sailingKieler commented Dec 6, 2023

As announced in the dev meeting yesterday - and although I don't see any urgency to merge it ASAP - here's my additional work on the generator:

@sailingKieler sailingKieler force-pushed the bump-yeoman-version-esm branch from 6849175 to c44e654 Compare December 6, 2023 14:28
@sailingKieler sailingKieler reopened this Dec 6, 2023
@sailingKieler sailingKieler changed the title Converted generator into an ESM package, bumped yeoman-generator dependency to vision ^7.0.0 Converted generator into an ESM package, bumped yeoman-generator dependency to vision ^6.0.0 Dec 6, 2023
@sailingKieler sailingKieler force-pushed the bump-yeoman-version-esm branch from ef0d095 to 563f11f Compare December 6, 2023 15:50
@sailingKieler
Copy link
Contributor Author

As indicated by the original title, I've prepared another change bumping to yeoman-generator@^7.0.0 (which took also quite notable time because of some nasty details).
However, some transitive dependency requires node 18, so I dropped that commit from this PR.
Will contribute it once #185 is merged.

…erator to ^6.0.0

bumped typescript version to ~4.7.0 to be able to
 * set tsConfig options 'module' and 'moduleResolution' to value of 'Node16', see https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html
 * deal with the transitive dependency 'mem-fs-editor' in version 10.0.x containing function alias assignments including type argument assignments, see https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#instantiation-expressions

Signed-off-by: Christian Schneider <[email protected]>
@sailingKieler sailingKieler force-pushed the bump-yeoman-version-esm branch from 563f11f to 6659779 Compare January 17, 2024 16:43
@sailingKieler
Copy link
Contributor Author

Since the ci build is now using Node18 (#193) I updated this branch and added my additional commit bumping the dependency of yeoman-generator to version 7.0.0.

@sailingKieler sailingKieler changed the title Converted generator into an ESM package, bumped yeoman-generator dependency to vision ^6.0.0 Converted generator into an ESM package, bumped yeoman-generator dependency to vision ^7.0.0 Jan 17, 2024
* upgraded the dependency of 'yeoman-test' already to '^8.0.0' because of a problematic dependency in '^7.0.0' ([email protected]...', has been by '[email protected]...')
* added a 'resolution' on '[email protected]', as that dependency is only referenced as peer-dependency by all up-to-date versions of using packages - which are not installed by yarn (in contrast to npm) -, but it's required at runtime; filed a request on Github to add '[email protected]' as a prod dependency to 'yeoman-generator': yeoman/generator#1495; besides '[email protected]' insists on 'mem-fs-editor@^10.0.3' (which depends on 'mem-fs@^3.0.0'), both declare "acceptDependencies" { "mem-fs": "^4.0.0" } - which again is not considered by yarn

Signed-off-by: Christian Schneider <[email protected]>
@sailingKieler sailingKieler force-pushed the bump-yeoman-version-esm branch from 6659779 to 99b4555 Compare January 17, 2024 16:56
@JonasHelming
Copy link
Contributor

Cool, just to make sure: have you tested all templates whether they work as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants