Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Make OAuth2 Proxy's allowed redirect domains configurable #357

Open
lucas-koehler opened this issue Sep 30, 2024 · 0 comments
Open
Labels
enhancement New feature or request prio-medium

Comments

@lucas-koehler
Copy link
Contributor

lucas-koehler commented Sep 30, 2024

Is your feature request related to a problem? Please describe.

The Theia Cloud Helm chart configures allowed redirect domains for session pods' OAuth proxies. This list is defined in the proxy's config map's whitelist_domains. This is currently hard coded to the landing page and session host. As this is also used for the redirects after logging out, only the landing page can be used as a redirect after logging out. This should be configurable.

Describe the solution you'd like

Extend the Helm chart to allow configuring the whitelist_domains and cookie_domains configurations. Also remove google.com from the default allowed redirects. This is likely a leftover.

@lucas-koehler lucas-koehler added the enhancement New feature or request label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio-medium
Projects
None yet
Development

No branches or pull requests

2 participants