Sync theia dark/light theme with electron nativeTheme setting #15037
Conversation
* Sync theia dark/light theme setting with electron nativeTheme setting * This is to have native tooltips matching to the dark/light setting of the current theme Fixes eclipse-theia#14075 Signed-off-by: Florian Richter <[email protected]>
There was a problem hiding this comment.
Thanks for the changes!
Apart from the minor improvements in the comment the code looks good to me 👍
For me this however does not seem to work. If i change the Theme in the Theia example app i always get the dark os theme. However, i should note, that i also get the dark theme on current master, even when i change my local theme to light.
Do you have any idea, where this might come from? Are you aware of any special settings in this regard that you have active? Which OS did you use to test?
| @@ -32,6 +32,10 @@ export function isHighContrast(scheme: ThemeType): boolean { | |||
| return scheme === 'hc' || scheme === 'hcLight'; | |||
| } | |||
|
|
|||
| export function isLightOrDark(type: ThemeType): 'light' | 'dark' { | |||
There was a problem hiding this comment.
Can we create a type for the 'light' | 'dark'? We use it quite a lot and it is originally a subtype of the ThemeType.
Additionally, the name isLightOrDark implies a boolean function imho. Can we either change this into:
- isLightTheme (which returns true for
hcLightandlight) (or the other way around, but i believe this makes the method more readable). - getThemeMode(), if we choose this variant i believe we should wrap
type === 'hc' || type === 'dark'in () to make it easier to understand.
What it does
This will sync the theia dark/light theme setting with electron nativeTheme setting.
This is to have native tooltips matching to the dark/light setting of the current theme.
Fixes #14075
How to test
Previously, the tooltip background color followed the system default. With this PR, the background color will align with theme currently selected in theia.
Follow-ups
Breaking changes
Attribution
Contributed by MVTec Software GmbH
Review checklist
Reminder for reviewers