-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GitHub Actions workflows #135
base: master
Are you sure you want to change the base?
Conversation
d1e9360
to
68acf21
Compare
68acf21
to
f9dbc33
Compare
The deleted workflows were mentioned in the documentation, right? So I assume they were meant to be triggered manually? Why do we not need them anymore? |
@tsmaeder Some of them were supposed to be triggered on a nightly schedule, see also the comment in #127. Note that I'm not well versed in this repo - it just seems to me like aside from the single Action left in this PR, none of the other actions were in use. In my mind, all of the deleted workflows cannot be aligned to the IP checks that we have to do. They check out arbitrary versions of VS Code and simply publish everything without performing IP checks. The only Action left is the one where we explicitly set the VS Code version, perform the IP checks with the Eclipse Foundation and then publish that specific version. |
That's correct - the two workflows that would build/publish nightly were in the relatively early days, before we performed regular IP Checks, and these workflows AFAIK have not been used in a few years... At the time, Theia could not reliably consume such bleeding edge built-ins anyway, lacking up-to-date vscode extensions API support. |
Continues the work of #127
ovsx-solid---publish-vscode-built-in-extensions-specific-version
. None of the deleted scripts were in use.workflow_dispatch
trigger now (instead of pushing to a specific branch).