Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect FSINFO trail signature in format function #47

Open
coran21 opened this issue Feb 5, 2024 · 1 comment
Open

Incorrect FSINFO trail signature in format function #47

coran21 opened this issue Feb 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@coran21
Copy link

coran21 commented Feb 5, 2024

Hello,

I believe the FSINFO trail signature 0xAA550000 is incorrectly stored in the buffer written to the media during the format function.

        /* Build the final signature word, this too is used to help verify that this is a FSINFO sector.  */
        byte_ptr[508] =  0x55;
        byte_ptr[509] =  0xAA;

According to the documentation:


FSI_TrailSig 508 4

Value 0xAA550000. This trail signature is used to validate that this is, in fact, an FSInfo sector. Note that the high 2 bytes of this value—which go into the bytes at offsets 510 and 511—match the signature bytes used at the same offsets in sector 0.


So, I believe that the correct code should be:

        /* Build the final signature word, this too is used to help verify that this is a FSINFO sector.  */
        byte_ptr[510] =  0x55;
        byte_ptr[511] =  0xAA;

Also, after I formatted the medium and checked it with fsck, I got this message:

FSINFO sector has bad magic number(s):
  Offset 508: 0x0000aa55 != expected 0xaa550000

Are there any plans to continue with development/bug fixing of Filex?

Thanks,

Petr

@coran21 coran21 added the bug Something isn't working label Feb 5, 2024
@rahmanih
Copy link

rahmanih commented May 9, 2024

Hi @coran21,

Indeed this is a confirmed bug.

regards
Haithem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants