Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonWebSignature2020 required header fields seem to be missing #32

Open
matgnt opened this issue Oct 27, 2023 · 1 comment
Open

JsonWebSignature2020 required header fields seem to be missing #32

matgnt opened this issue Oct 27, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@matgnt
Copy link

matgnt commented Oct 27, 2023

I've been debugging some MIW credentials and the header of the jws seems to look like this:

{"alg": "EdDSA"}

According to:

https://w3c.github.io/vc-jws-2020/#json-web-signature-2020

the header should contain a bit more:
I used this one here to compare:
https://github.com/decentralized-identity/JWS-Test-Suite/blob/39547f5dc6da289a3f7e460fd6b782b9c9dc898b/data/presentations/presentation-1.json#L47

{"b64": false, "crit": ["b64"], "alg": "EdDSA"}

I think this is required for kind of backward compatibility, that implementations without support for detached sigs can recognize and fail because at least they understand the crit list of required fields.

--
Matthias Binzer

@matgnt matgnt added documentation Improvements or additions to documentation bug Something isn't working and removed documentation Improvements or additions to documentation labels Oct 27, 2023
@koptan
Copy link
Contributor

koptan commented Oct 30, 2023

Assigned to @koptan,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants