Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build/release workflow #65

Closed
carslen opened this issue Nov 29, 2023 · 2 comments
Closed

Refactor build/release workflow #65

carslen opened this issue Nov 29, 2023 · 2 comments
Assignees

Comments

@carslen
Copy link
Contributor

carslen commented Nov 29, 2023

I know, you're in the middle of the transition to build/publish your artefacts. But I want to point out, that it is not sufficient to publish the cx-ssi-lib to maven central and create a corresponding GH tag in the eclipse-tractusx/cx-ssi-lib.

Please do the following instead:

  • create a GH release (e.g. v0.17.0)
  • attach the build artefact to the GH release
  • publish the build artefact at Maven Central

Please refactor build/release workflow. Maybe the GH action release-please could help you building your build/release workflow.

Extra hint:
Please maintain CHANGELOG.md file. You published at Maven Central, but your Changelog has no v0.17.0 but content in Unreleased.

related to eclipse-tractusx/managed-identity-wallet#167

@borisrizov-zf
Copy link
Contributor

@carslen
Thanks for the tips!

This release was both an experiment and a release, as the 23.12 overall release is pressing, I had to make sure we're able to make package releases which are available through Maven and make the MIW compliant with the TRGs.

I'll update the CHANGELOG.md to reflect the current state of the code and add an issue to track progress on the automation of the GitHub release process, as we have some catch-up to do code-wise.

@borisrizov-zf
Copy link
Contributor

PRs #66 and #68 cover most of the points. Issue #67 is created to tackle the automation of the GH release.

Please advice if we can safely close this issue now.

@carslen carslen closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants