Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POLICY_STORE] Multi-Filter support for API endpoint GET /irs/policies #750

Closed
6 of 7 tasks
mkanal opened this issue Jul 2, 2024 · 6 comments
Closed
6 of 7 tasks
Assignees
Labels
3 - Maintenance & Improvements (EDC & EDC API) Improvements policy_store Issues regarding the IRS policy store. R24.8

Comments

@mkanal
Copy link
Contributor

mkanal commented Jul 2, 2024

As api endpoint consumer
I want filter for multiple columns at one time
so that I am able to filter policies based on my specific request

Links

Hints / Details

  • API endpoint GET /irs/policies supports no filter support attribute

Acceptance Criteria

  • Enable multiple filter support on all attributes with AND combination
    • Datatype: String supports Operator equals
    • Datatype: Date supports Operator (Date Range, Date from, Date to)
  • Add autocompletion for district values [startsWith A%] (limited by 100 entries)
  • Convert GET to POST endpoint POST /policies/paged
 "searchCriteria": {
        "filter": [
            "channel,EQUAL,SENDER,AND"
        ]
    }

Out of Scope

  • Multi filter support on column "Constraints"
  • Enable multiple filter support on all attributes with OR combination - results with NotSupported Exception
@mkanal mkanal added this to IRS Jul 2, 2024
@github-project-automation github-project-automation bot moved this to inbox in IRS Jul 2, 2024
@mkanal mkanal added policy_store Issues regarding the IRS policy store. 3 - Maintenance & Improvements (EDC & EDC API) Improvements labels Jul 2, 2024
@mkanal mkanal changed the title Multi-Filter support for API endpoint GET /irs/policies [POLICY_STORE] Multi-Filter support for API endpoint GET /irs/policies Jul 2, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jul 3, 2024

@dsmf Please clarify

  • Is OR combination really needed and currently supported by Trace-X.
  • Date and String filtering
  • Autocompletion for Sting values

@mkanal mkanal added the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Jul 3, 2024
@dsmf
Copy link
Contributor

dsmf commented Jul 4, 2024

Not needed:

  • Filtering using OR operator is not needed according to @ds-mwesener.

Already implemented in #639:

  • Sorting by the date fields createdOn and validUntil asc, desc.
  • Filtering by multiple fields.

The following needs to be implemented in the current story:

  • Filtering by the date fields createdOn and validUntil
  • This should be implemented as follows (according to @mkanal):
search=<dateFieldName>,AFTER_LOCAL_DATE,<YYYY-MM-DD>&search=<dateFieldName>,BEFORE_LOCAL_DATE,<YYYY-MM-DD>
  • A Separate autocomplete endpoint that only returns distinct results for the requested field with a limit (no paging).

The following stories are also needed:

PBIs should be created for the following required functionalities:

dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
…ollection

added:
- page parameter
- size parameter
- search by policyId
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 9, 2024
@mkanal mkanal moved this from inbox to backlog in IRS Jul 9, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 12, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 12, 2024
@dsmf dsmf moved this from backlog to wip in IRS Jul 12, 2024
@dsmf dsmf self-assigned this Jul 12, 2024
@dsmf
Copy link
Contributor

dsmf commented Jul 12, 2024

Outcome

Date filter createdOn and validUntil

PR: #798

Autocomplete Endpoint

  • Added autocomplete endpoint Policy Store API: GET /irs/policies/attributes/{attribute}.
  • Added request to the insomnia IRS_Request_Collection, see "Policy attribute auto-complete"
  • OpenAPI documentation incl. adjustements in irs-api.yaml

PR: #799

PBIs

dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 12, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 12, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 12, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 12, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 12, 2024
…o fix test IrsApplicationTests.generatedOpenApiMatchesContract
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 12, 2024
… a list of all assigned business partner numbers
@mkanal mkanal added the R24.8 label Jul 15, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
… a list of all assigned business partner numbers
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 15, 2024
@dsmf dsmf moved this from wip to test in IRS Jul 15, 2024
@ds-kgassner
Copy link
Contributor

Successfully tested:

  • Added possibility to filter by createdOn and validUntil to Policy Store API: GET /irs/policies/paged:
  • Added autocomplete endpoint Policy Store API: GET /irs/policies/attributes/{attribute}.
  • Added request to the insomnia IRS_Request_Collection, see "Policy attribute auto-complete"

@ds-jhartmann ds-jhartmann moved this from test to review in IRS Jul 15, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jul 22, 2024

Merge is outstanding.

@mkanal mkanal moved this from review to test in IRS Jul 22, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jul 22, 2024

AC -> Convert GET to POST endpoint POST /policies/paged will be transferred to
#802
#803
LGFM PO acceptance in behalf of @jzbmw

@mkanal mkanal closed this as completed Jul 22, 2024
@mkanal mkanal moved this from test to done in IRS Jul 22, 2024
@dsmf dsmf mentioned this issue Jul 23, 2024
2 tasks
@dsmf dsmf removed the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Maintenance & Improvements (EDC & EDC API) Improvements policy_store Issues regarding the IRS policy store. R24.8
Projects
Status: done
Development

No branches or pull requests

3 participants