Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: better release workflow #199

Open
Tracked by #205
borisrizov-zf opened this issue Dec 7, 2023 · 0 comments
Open
Tracked by #205

ci: better release workflow #199

borisrizov-zf opened this issue Dec 7, 2023 · 0 comments

Comments

@borisrizov-zf
Copy link
Contributor

Summary

During the release of v0.3.0 (merge of develop into main) a couple of weaknesses have become apparent:

  • The semantic release automation MUST be fed conventional commits, otherwise it won't build the correct application version or won't even trigger
  • Mangled CHANGELOG.md when not following a procedure (this procedure was unclear up until now)

Solution

Add instructions in CONTRIBUTING.md:

  • how to properly rebase branches before creating a PR
  • pre-flight checks when creating a PR
  • committer checklist before approving a PR

General next steps:

  • REJECT PRs containing any kind of faulty git messaging
  • The automatic commit on main must be immediately merged back into develop to avoid a messy CHANGELOG.md during the next release (potential to automate this)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant