We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently DeliveryRequestApiService.handleDeliverySubmodelRequest always aborts mapping of internal delivery information to a partner, if the partner is not a supplier.
DeliveryRequestApiService.handleDeliverySubmodelRequest
Likely the check has been introduced to steer the direction of the two-sided information without a dedicated
Note: We added the check during #382. Further checking than previously makes sense, but was not sufficient / partly wrong.
Depending on the Incoterm and the partner relationship the delivery information needs to be validated.
The IncotermEnumeration already lists the responsibility:
IncotermEnumeration
CUSTOMER
SUPPLIER
PARTIAL
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Description
Current behaviour
Currently
DeliveryRequestApiService.handleDeliverySubmodelRequest
always aborts mapping of internal delivery information to a partner, if the partner is not a supplier.Likely the check has been introduced to steer the direction of the two-sided information without a dedicated
Note: We added the check during #382. Further checking than previously makes sense, but was not sufficient / partly wrong.
Expected behavior
Depending on the Incoterm and the partner relationship the delivery information needs to be validated.
The
IncotermEnumeration
already lists the responsibility:CUSTOMER
= Customer creates the delivery information. Supplier asks for itSUPPLIER
= Supplier creates the delivery information. Customer asks for itPARTIAL
= both appliesSteps to reproduce the Bug
The text was updated successfully, but these errors were encountered: