Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer can't refresh Delivery Information #432

Closed
tom-rm-meyer-ISST opened this issue Jun 3, 2024 · 0 comments · Fixed by #435
Closed

Customer can't refresh Delivery Information #432

tom-rm-meyer-ISST opened this issue Jun 3, 2024 · 0 comments · Fixed by #435
Labels
bug Something isn't working

Comments

@tom-rm-meyer-ISST
Copy link
Contributor

tom-rm-meyer-ISST commented Jun 3, 2024

Description

Current behaviour

Currently DeliveryRequestApiService.handleDeliverySubmodelRequest always aborts mapping of internal delivery information to a partner, if the partner is not a supplier.

Likely the check has been introduced to steer the direction of the two-sided information without a dedicated

Note: We added the check during #382. Further checking than previously makes sense, but was not sufficient / partly wrong.

Expected behavior

Depending on the Incoterm and the partner relationship the delivery information needs to be validated.

The IncotermEnumeration already lists the responsibility:

  • CUSTOMER = Customer creates the delivery information. Supplier asks for it
  • SUPPLIER = Supplier creates the delivery information. Customer asks for it
  • PARTIAL = both applies

Steps to reproduce the Bug

  • Start applications (no role)
  • use the postman collection for integration test to seed data
  • try to refresh data on the dashboard as a customer from the supplier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant