Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRG-Check Pipeline Issues #341

Open
ds-mwesener opened this issue Nov 8, 2023 · 9 comments
Open

TRG-Check Pipeline Issues #341

ds-mwesener opened this issue Nov 8, 2023 · 9 comments
Assignees

Comments

@ds-mwesener
Copy link

Is your support request related to a problem? Please describe.
Failing trg-checks in pipeline.

Pipeline Run

Describe the solution you'd like
Due to a correct configuration I expect the pipeline to be successful.

Additional context
Already talked to @SebastianBezold regarding my issues.

@almadigabor almadigabor self-assigned this Nov 8, 2023
@SebastianBezold SebastianBezold self-assigned this Nov 8, 2023
@SebastianBezold
Copy link
Contributor

As i already suspected, our current implementation of the non root user check does not resolve the variable references used in USER ${UID}:${GID}. It's currently seen as invalid user. I'll see, if we can improve the check to also resolve that and then have it as valid user.

The Dockerfile is following the TRGs correctly. The automation itself is the issue here.

@SebastianBezold
Copy link
Contributor

The Chart rendering fails with following error:
"traceability-foss/charts/frontend/templates/deployment.yaml" at <.Values.imagePullSecret.dockerconfigjson>: nil pointer evaluating interface {}.dockerconfigjson

Running helm template on the Chart directly works as expected. I'll check if there is a know issue or newer version of the helm library we use

@tomaszbarwicki
Copy link
Contributor

Yes, it is a known, reported issue: helm/helm#12385

@SebastianBezold
Copy link
Contributor

Ah cool thanks for pointing out. Didn't know that it is even reported by you 😁

@tomaszbarwicki
Copy link
Contributor

tomaszbarwicki commented Jan 29, 2024

Hi @ds-mwesener, apologies for late response, it seems the latest fix to quality check tool covers your case (Helm Chart which is unable to render. I tested it on the provided forked repo and on the original at tractus-x, both went through. Please try run it again and let us know the result.

cc: @FaGru3n

@almadigabor
Copy link
Contributor

Hey @ds-mwesener! Does the trg check show correct results now? If yes, I would close this issue.

@FaGru3n
Copy link
Contributor

FaGru3n commented Mar 12, 2024

If your fine with the result i would close this issue, feel free to reopen if there are further questions.

@FaGru3n FaGru3n closed this as completed Mar 12, 2024
@ds-mwesener
Copy link
Author

ds-mwesener commented Mar 12, 2024

@ds-mwesener ds-mwesener reopened this Mar 12, 2024
@hzierer hzierer added backlog and removed support labels Apr 12, 2024
@hzierer
Copy link

hzierer commented Apr 12, 2024

moved to our backlog to plan it properly

@FaGru3n FaGru3n removed the backlog label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants