Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Support of Company Short Names #812

Open
1 of 20 tasks
ybidois opened this issue Jul 19, 2024 · 10 comments
Open
1 of 20 tasks

Better Support of Company Short Names #812

ybidois opened this issue Jul 19, 2024 · 10 comments
Assignees
Labels
portal Feature/Bug for Portal component Prep-R24.12 Prep-R25.03
Milestone

Comments

@ybidois
Copy link

ybidois commented Jul 19, 2024

Overview

Explain the topic in 2 sentences

The Portal registration flow and its overall UX and UI must be compatible with our customers' legal and short names.

What's the benefit?

Allow all customers to register smoothly with both their legal names and identifiers:

  • Have legal name used only where it is needed
  • Use short name everywhere else
  • Great UX/UI integration

What are the Risks/Dependencies ?

  • BPDM
  • Wallet
  • Gaia-X Clearing House

Detailed explanation

Current implementation

  • Legal name used everywhere

Proposed improvements

  • Customer registration:
    • Allow the use of any legal name based on country specificity
    • Allow the choice of a short name with limited characters
  • Use the brand name in all subsequent fields, unless the legal name is required
  • Where the legal name is required, adjust the UI
  • Where the short name can be used, adjust the UI

Feature Team

Contributor

Committer

Issues

eclipse-tractusx/portal-frontend#993
eclipse-tractusx/portal-frontend#1007

User Stories

Acceptance Criteria

  • Portal should support countries as per the Catena-X official White List (+ Yellow List under certain conditions).
  • 100% of all legal names in the countries we officially support are accepted in the registration process
    • Very long names
    • Country-specific with unique characters
  • Legal names are used only where required, brand names are otherwise used
  • OSP functionality should also comply with the defined requirements

Test Cases

  • For each supported country, successful registration of an edge case legal name (very long or special characters) + identifier
  • Short names are used and displayed across:
    • Registration process
    • User invitation process
    • Company detail pages
    • App release process
    • Service release process

Architectural Relevance

The following items are ensured (answer: yes) after this issue is implemented:

Justification: (Fill this out, if at least one of the checkboxes above cannot be ticked. Contact the Architecture Management Committee to get an approval for the justification)

Additional information

  • I am aware that my request may not be developed if no developer can be found for it. I'll try to contribute a developer (bring your own developer)
@ybidois ybidois added portal Feature/Bug for Portal component Prep-R24.12 labels Jul 29, 2024
@ybidois ybidois self-assigned this Jul 29, 2024
@stephanbcbauer
Copy link
Member

@ybidois not sure about this feature. Is it planned to present it in tomorrow's planning? It was never presented in a Refinement meeting. Did we miss something?

@stephanbcbauer stephanbcbauer added this to the 24.12 milestone Aug 1, 2024
@stephanbcbauer stephanbcbauer moved this from Inbox to Backlog in Release Planning Aug 1, 2024
@Sebastian-Wurm
Copy link

@nicoprow
Copy link

nicoprow commented Aug 1, 2024

  • Regarding identifier types, we have an overlap with Harmonization and Enhancement of identifier types #605. Let's work together here.

    * We probably want to store the REGEX in BPDM rather than in the Portal. @nicoprow: Please confirm.
    * Regarding GXDCH identifier types, there is a first implementation proposal for portal-backend here: [Add new BPDM identifier types portal-backend#895](https://github.com/eclipse-tractusx/portal-backend/issues/895)
    
    • Regarding "brand name": please use the term "short name" from BPDM as defined in CX-0012.

Any validation on the identifier types eventually also needs to be performed in the Pool. Yea we will need to align on the REGEX and we can also make it available over the BPDM API to reduce duplication and reduce the risk of mismatched validations.

@ybidois
Copy link
Author

ybidois commented Aug 1, 2024

Hi @Sebastian-Wurm, @nicoprow, I agree with what you propose:

  • Using the short name → I updated the feature description accordingly
  • Aligning on REGEX, storing in BPDM, and making it available over BPDM API
    It will reduce a lot of errors on all sides.

Let me check with @evegufy and the Open-Source Portal team the best way to work together on this and we will get back to you.

@ybidois ybidois removed this from the 24.12 milestone Oct 24, 2024
@ybidois
Copy link
Author

ybidois commented Oct 24, 2024

As discussed with @evegufy, we will bring our changes in 25.03 instead!

@ybidois
Copy link
Author

ybidois commented Nov 7, 2024

Updated with new template

@typecastcloud
Copy link

The scope feels very different for short name + identifier changes.

  1. Short name UX/UI adjustments with clear REGEX to limit length and characters
  2. Identifier validation in general and especially with dependency to BPDM validation

Maybe a bit late to split up.

Was there already some refinement on what methods BPDM team wants to provide?

@ybidois
Copy link
Author

ybidois commented Nov 11, 2024

I don't think it's too late to split the scope. We could keep this one for names as names extend beyond the registration process and have identifiers as part of the Registration Process Improvements here → #966.

@ybidois ybidois changed the title Better Support of Legal Names and Identifiers Better Support of Legal Names Nov 11, 2024
@ybidois ybidois changed the title Better Support of Legal Names Better Support of Legal and Short Names Nov 11, 2024
@ybidois ybidois changed the title Better Support of Legal and Short Names Better Support of Company Short Names Nov 11, 2024
@stephanbcbauer
Copy link
Member

Some hints from Release Management (@ther3sa) and Tractus-X Project Lead (@stephanbcbauer)

  • Please add missing sections from the feature template, or fill them out
  • Please add committer

@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Nov 11, 2024
@evegufy evegufy moved this from NEW USER REQUEST to BACKLOG in Portal Nov 11, 2024
@evegufy
Copy link
Contributor

evegufy commented Nov 12, 2024

Committers:
@oyo
@ntruchsess
@Phil91
@evegufy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portal Feature/Bug for Portal component Prep-R24.12 Prep-R25.03
Projects
Status: BACKLOG
Status: Backlog
Development

No branches or pull requests

7 participants