Is tycho-surefire-plugin honoring the p2.inf instructions when testRuntime=default ?

[henryju]

Hi,

We are trying to use platform-specific fragments in our plugin. Since those fragments include executable binaries, we have this idea of avoiding the cost of extraction in a temporary folder at every startup by asking Eclipse to install the bundle "exploded" (Eclipse-BundleShape: dir).
Since the ZIP/JAR format doesn't support permissions, I have added a p2.inf file in each fragment to restore permissions at installation time:

instructions.install = \
    chmod(targetDir:@artifact,targetFile:bin,permissions:755,options:-R);
 instructions.install.import= \
    org.eclipse.equinox.p2.touchpoint.eclipse.chmod

This is working fine when doing manual testing, but not during the JUnit tests. The fragment is correctly exploded by Tycho, but I have the impression that p2.inf instructions are ignored.
I gave a try to change to <testRuntime>p2Installed</testRuntime> and now the permissions are correctly set in the exploded bundle (but I have other failures now).

I read that <testRuntime>p2Installed</testRuntime> is experimental, so my question is: am I forced to use this mode if I want the chmod instruction to be executed?

[laeubi]

@henryju p2.inf touchpoints are only honored when using the <testRuntime>p2Installed</testRuntime>

I read that p2Installed is experimental

I think it is a bit misleading, but for sure it is not used very often and a rather special case like this.

permissions:755

By the way making is readable and executable for everyone is probably a security risk

[henryju]

The error I get is:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.5:test (default-test) on project org.sonarlint.eclipse.core.tests: Error while executing platform: The launcher bundle org.eclipse.equinox.launcher_*.jar was not found in /home/julien.henry/Projects/sonarlint/sonarlint-eclipse/org.sonarlint.eclipse.core.tests/target/work/plugins

[laeubi]

Can you provide an integration-test to demonstrate the issue? Are you using latest Tycho release? Anything special (e.g. running on mac or similar?)....

[henryju]

I am using Tycho 4.0.5, on Linux. Since my project is a feature and not a full product, I have the impression I need somehow to tell Tycho what product to "materialize" to create the test environment.
I tried to add:
<profileName>epp.package.jee</profileName>
but it makes no difference.
Maybe I should change something in my target platform.

I can try to write an integration test.

[laeubi]

You don't necessarily should need a product, maybe you can try to specify the launcher as an explicit dependency but I think the best would be if tycho can figure it out automatically so probably a good opportunity to improve this feature.

The profile name could be indeed a problem if you are referencing a full product.

[henryju]

maybe you can try to specify the launcher as an explicit dependency

How would you do that?

I tried to add:

          <plugin>
            <groupId>org.eclipse.tycho</groupId>
            <artifactId>tycho-surefire-plugin</artifactId>
            <configuration>
              <dependencies>
		<dependency>
                  <type>p2-installable-unit</type>
                  <artifactId>org.eclipse.equinox.launcher</artifactId>
                </dependency>

but it seems to have no effect.