Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write base set of extra PublisherSubscriberTest for up-transport-zenoh-cpp #58

Closed
gregmedd opened this issue Jun 22, 2024 · 5 comments · Fixed by #65
Closed

Write base set of extra PublisherSubscriberTest for up-transport-zenoh-cpp #58

gregmedd opened this issue Jun 22, 2024 · 5 comments · Fixed by #65
Assignees
Milestone

Comments

@gregmedd
Copy link
Contributor

“Extra” tests in a transport library provide an opportunity to exercise end-to-end layer communication. Layer 2 tests do not contribute to coverage for transport libraries since transport implementations are entirely layer 1. However, layer 2 tests are critical in evaluating the health and performance of a transport implementation.

This test will validate the interoperability between Publisher and Subscriber over Zenoh. It should verify that published messages arrive with all data intact and are received only by the intended subscribers. Additionally, it should verify, to the extent possible, that messages can be exchanged between threads, processes, and across the (loopback) network. Where possible, it should also make assertions about performance and validate message handling under load.

@gregmedd gregmedd converted this from a draft issue Jun 22, 2024
@gregmedd gregmedd moved this from Backlog to In progress in C++ uProtocol Development Jun 27, 2024
@gregmedd gregmedd linked a pull request Jul 29, 2024 that will close this issue
@gregmedd gregmedd added this to the alpha.4 milestone Jul 30, 2024
@gregmedd gregmedd changed the title Write extra PublisherSubscriberTest for up-transport-zenoh-cpp Write base set of extra PublisherSubscriberTest for up-transport-zenoh-cpp Jul 30, 2024
@gregmedd
Copy link
Contributor Author

#65 contained the bare minimum, but it should be expanded to check multiple publishers and subscribers and verify messages go to the right places.

@gregmedd gregmedd moved this from In progress to Ready in C++ uProtocol Development Jul 30, 2024
@gregmedd
Copy link
Contributor Author

Note: this has been split. This task will focus on just enough testing to move development forward, and the rest will be handled in #74

@billpittman
Copy link
Contributor

I'll take this task.

@gregmedd gregmedd moved this from Ready to In progress in C++ uProtocol Development Aug 8, 2024
@gregmedd
Copy link
Contributor Author

gregmedd commented Aug 8, 2024

@billpittman - Go for it. Note that a test already exists for this, so the P0 task is just to take a look at that and determine if any additional assertions or tests are critical to unblocking development right now. Extending it with full coverage of use cases and configurations can be handled in #74.

@billpittman
Copy link
Contributor

Fixed by #92 at least for the basic tests.

@gregmedd gregmedd moved this from In review to Done in C++ uProtocol Development Aug 12, 2024
@gregmedd gregmedd closed this as completed by moving to Done in C++ uProtocol Development Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants