Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow custom license header for app code #194

Open
eriksven opened this issue Sep 6, 2023 · 1 comment
Open

[Feature]: Allow custom license header for app code #194

eriksven opened this issue Sep 6, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eriksven
Copy link

eriksven commented Sep 6, 2023

Description

Among other things, the pre-commit task checks that all relevant files in the repoisoty contain the license header defined in license-header.txt . For the files provided by Eclipse Velocitas project that are not touched by a user of the template this might be ok. However, for the application in app/src a developer most likely wants to set another copyright notice or even other license.
So there should be a way to do this without having the pre-commit check failing or rewriting the license header to header from Eclipse Velocitas project.

Suggested Solution

Allow the definition of a second license file which is only enforced for files in app/src.

Alternatives

  • Disable the license check at all, at least for the app directory
  • Enable the license check only for *.py files and thus only for the application. This assumes that the repository does not contain any other *.py files maintained by the Eclipse Velocitas team.

Additional Context

No response

@eriksven eriksven added the enhancement New feature or request label Sep 6, 2023
@kse3hi
Copy link
Contributor

kse3hi commented Sep 7, 2023

Thank you @eriksven for feature request. We will consider it.

@kse3hi kse3hi moved this from 🆕 New to 📋 Backlog in Velocitas Backlog Sep 7, 2023
@kse3hi kse3hi added the good first issue Good for newcomers label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants