Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Upgrading debian/ubuntu packaged removes the zenoh-bridge-ros2dds user and /etc/zenoh-bridge-ros2dds directory. #78

Closed
aosmw opened this issue Feb 2, 2024 · 2 comments · Fixed by #121
Labels
bug Something isn't working

Comments

@aosmw
Copy link

aosmw commented Feb 2, 2024

Describe the bug

Using apt to install an update of zenoh-bridge-ros2dds triggers a removal of the zenoh-bridge-ros2dds user and the /etc/zenoh-bridge-ros2dds directory.

The upgrade fails if the service is in use by the zenoh-bridge-ros2dds user.

The upgrade should not remove the existing conf.json5 file. (It contained hard earned configuration settings :/ ).

The default file config file could possibly installed in /lib/share/zenoh-bridge-ros2dds/default_conf.json5

If a /etc/zenoh-bridge-ros2dds/conf.json5 does not exist then it might fallback to the installed /lib/share/zenoh-bridge-ros2dds/default_conf.json5. I am making this up. There is probably a proper debian way to handle configuration files and service restarts during upgrades.

To reproduce

  1. Attempt to upgrade a running zenoh-bridge-ros2dds service with a customised config.
  2. The upgrade will fail until the service is stopped.
  3. Any previous config will be replaced with a default config.

System info

  • Ubuntu 22.04.3 LTS
  • [2024-02-02T03:05:46Z INFO zenoh_bridge_ros2dds] zenoh-bridge-ros2dds v0.10.1-rc.2 built with rustc 1.72.0 (5680fa18f 2023-08-23
@aosmw aosmw added the bug Something isn't working label Feb 2, 2024
@JEnoch
Copy link
Member

JEnoch commented Feb 2, 2024

Sorry about your lost config!
We need to have a look on how a Debian package is supposed to handle updates in a proper way.

@JEnoch
Copy link
Member

JEnoch commented Apr 23, 2024

The proper way seems to declare the configuration file in a conffiles file within the Debian package.
Addressed in #121.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants