Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDI dependency to the API module #215

Open
xstefank opened this issue Nov 1, 2019 · 2 comments
Open

Add CDI dependency to the API module #215

xstefank opened this issue Nov 1, 2019 · 2 comments

Comments

@xstefank
Copy link
Member

xstefank commented Nov 1, 2019

Since every HealthCheck must be a CDI bean would it make sense to add CDI dependency directly to the API module? Then to start with MP Health all you need is only one dependency (Health API).

@donbourne
Copy link
Member

Is it possible today, without CDI, to have /health/ready and /health/live simply answer whether the server is up and app(s) is running without any explicit HealthChecks and without CDI? If so, I'd be hesitant to add an explicit dependency on CDI for the Health API.

@xstefank xstefank changed the title Add CDI dependenci to the API module Add CDI dependency to the API module Nov 2, 2019
@xstefank
Copy link
Member Author

xstefank commented Nov 2, 2019

@donbourne yes, you are right. However, the question then is whether users rather use default behavior (no checks executed, liveness and readiness are the same, so only HC is used as a normal ping) or they define their own custom checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants