Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mypy #5

Open
kinow opened this issue Nov 29, 2022 · 0 comments
Open

Add Mypy #5

kinow opened this issue Nov 29, 2022 · 0 comments

Comments

@kinow
Copy link
Contributor

kinow commented Nov 29, 2022

When I use pyflow in a project to develop a workflow, I get a few warnings in my IDE that could be detected with Mypy. I am preparing a PR for the kwargs in families, suites, etc. But I thought perhaps a future enhancement could be to adopt Mypy? That could help detecting simple typing issues too, receiving contributions from others (i.e. enforcing that we are all aware of the types used), and also enable to someday use other linters or performance tools like mypyc.

For example of the warnings (see yellow-ish background colored text):

image

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant