Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation_checks warning #62

Open
rostal opened this issue Jan 30, 2025 · 0 comments
Open

validation_checks warning #62

rostal opened this issue Jan 30, 2025 · 0 comments

Comments

@rostal
Copy link

rostal commented Jan 30, 2025

It seems like the validation_checks is warning that there are duplicate entries in the log, even when all entry_field_dupe are all false, I think the code needs to be changed from:

if (any(!preprocess_log$entry_field_dupe)) {
      rlang::warn("Detected duplicate entry-field combination. The same item has been corrected at least twice in the log")
    }

to

if (any(!preprocess_log$entry_field_dupe) == TRUE) {
      rlang::warn("Detected duplicate entry-field combination. The same item has been corrected at least twice in the log")
    }

It is just a warning and doesn't break the code, but it might confuse people who see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant