You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After applying #84 and setting the margin to zero I find that it is possible for the cursor to completely disappear off the bottom of the viewpoint as if the point that is being checked to see if it is still visible is the very top of the rectangular area that comprises each glyph. After checking more closely I can see that the same thing applies when the cursor goes off to the right of the scroll area but it is less obvious (probably because the particular size and font size I was using during testing meant that the scroll area was not an exact multiple of the font width and height but the height had the smaller mismatch!)
I suspect that the check for whether the something is visible is only checking one point in (void) TextEditorWidget::scrollPositionVisible(int xPosIn, int yPosIn) whereas it should check the diagonally opposite corners of the I-cursor (or perhaps the character before/after and the top/bottom of the row it is in depending on which way the cursor has last moved? 🤷♂️)
I had actually extended PR 84 to work with a QSize instead so that the horizontal and vertical margins could be set separately but I had set them to the same value (zero) when I found this.
The text was updated successfully, but these errors were encountered:
After applying #84 and setting the margin to zero I find that it is possible for the cursor to completely disappear off the bottom of the viewpoint as if the point that is being checked to see if it is still visible is the very top of the rectangular area that comprises each glyph. After checking more closely I can see that the same thing applies when the cursor goes off to the right of the scroll area but it is less obvious (probably because the particular size and font size I was using during testing meant that the scroll area was not an exact multiple of the font width and height but the height had the smaller mismatch!)
I suspect that the check for whether the something is visible is only checking one point in
(void) TextEditorWidget::scrollPositionVisible(int xPosIn, int yPosIn)
whereas it should check the diagonally opposite corners of theI
-cursor (or perhaps the character before/after and the top/bottom of the row it is in depending on which way the cursor has last moved? 🤷♂️)I had actually extended PR 84 to work with a
QSize
instead so that the horizontal and vertical margins could be set separately but I had set them to the same value (zero) when I found this.The text was updated successfully, but these errors were encountered: