Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simdjson 0.9.0 #69

Closed
eddelbuettel opened this issue Mar 18, 2021 · 7 comments
Closed

simdjson 0.9.0 #69

eddelbuettel opened this issue Mar 18, 2021 · 7 comments

Comments

@eddelbuettel
Copy link
Owner

This seems related to #53 in that the on-demand API is now put to the fore (per the tweet announcement by @lemire).

Sadly, just copying the two singleheader/ files in as I attempted in a branch breaks our compilation in lots of places 😢

@lemire
Copy link
Collaborator

lemire commented Mar 18, 2021

@eddelbuettel We fully support the DOM API. I am sure it is only small stuff that fails.

@lemire
Copy link
Collaborator

lemire commented Mar 18, 2021

Oh. I see. I will prepare a pull request.

@lemire
Copy link
Collaborator

lemire commented Mar 18, 2021

I am working on a pull request. We effectively blocked what you are doing which is bypassing entirely the error handling. The way you did it is fine, I am sure, but people would bypassing checking the error and they complaining that they were getting garbage... so we are now forcing people to handle errors or to have exceptions.

People doing no error checking at all is a nightmare for us.

@eddelbuettel
Copy link
Owner Author

eddelbuettel commented Mar 18, 2021

Thank you so much. @knapply is currently in transit but hopes to get a chance to look at it later today. There is not need to rush, I guess, as there are really two possible approaches

  • renable DOM we used / are using
  • change our code to on-demand (which we already planned by didn't get to yet), see On Demand API  #53

And latter one is, I guess, preferred by all but a little more work.

@lemire
Copy link
Collaborator

lemire commented Mar 18, 2021

@eddelbuettel There is no need to reenable anything. You will see.

@lemire
Copy link
Collaborator

lemire commented Mar 18, 2021

On Demand (#53) would definitively be the way forward. It would enable really cool things and improve performance.

@eddelbuettel
Copy link
Owner Author

We have 1.0.0; the on-demand feature is still WIP and harder given R's memory interface...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants