Telemetry support

[ghost]

Are you planning to add telemetry support to the library? I can help with a PR.
Maybe it should be added in hackney.

[edgurgel]

Great question! I think we should do this inside hackney.

I know that hackney uses erlang-metrics as interface so two options (I think?):

• Replace erlang-metrics with telemetry
• Implement a backend for erlang-metrics with telemetry ?

[ghost]

erlang-metrics and hackney being the same creator, I think it's up to him to see if he wants to migrate to telemetry and have apps with erlang-metrics migrating to telemetry as well.

If we are not implementing this into httpoison this discussion should be in https://github.com/benoitc/hackney and could be closed.

[PhillippOhlandt]

I would love telemetry support. Right now, I have a use case where I want to be notified after every request with all the request and response infos.

[ghost]

What I have done now is a lib that I used on top of httpoison where I have added my telemetry metrics.

[binaryseed]

Any further thoughts on this? It'd be nice to get telemetry integrated somewhere :)

Ideally, we'd follow the recommendations for emitting start, stop and failure events, which will enable tracing as well as metrics collection...

[GregMefford]

Just stopping by to say that I'm also interested - I agree that it would be useful to get it added in Hackney itself, but that doesn't preclude HTTPoison also adding it, so that we get it one way or the other. 😉

[3fernandez]

Hi there! 🙂

I'm working on an XML tool that leverages use HTTPoison.Base, and I'm trying to instrument it using use NewRelic.Tracer. But I don't see how the pieces should fit together. Any advices or tips?

Thanks

[zoidyzoidzoid]

@3fernandez I think we wanna emit start/stop/failure events, like @binaryseed mentioned, sort of like:

:telemetry.execute([:ecto, :repo, :init], %{system_time: System.system_time()}, %{repo: repo, opts: opts})

That example is from a Telemetry Ecto example, but in lib/httpoison/base.ex, where instead of repo and opts we'd send some information about the request, maybe some of these fields from opentelemetry_phoenix could work as inspiration here

[zoidyzoidzoid]

The upstream hackney ticket is still open, so I think this one is still unsolved too?

[ghost]

I am closing long opened issues on my account to make some cleanup.

[zoidyzoidzoid]

I think it'd be great to track this feature request for httpoison, and track the upstream hackney ticket.

Would I need to make my own ticket that is a dupe of this closed ticket be the ideal solution for you?

[ghost]

Yes sure.

[edgurgel]

https://medium.com/the-realreal-product-tech-blog/monitoring-hackney-connection-pools-with-telemetry-3aaeafa8eeb8