From c613f8ade3dce930b2479b3061620e159f6374bc Mon Sep 17 00:00:00 2001
From: MAHDTech <MAHDTech@saltlabs.tech>
Date: Thu, 26 Sep 2024 13:15:51 +1000
Subject: [PATCH] fix: missing gmac

---
 README.md                                              |  2 +-
 .../Platform/OrangePi/OrangePi5Pro/OrangePi5Pro.dsc    | 10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 470b4ff4..50eb4e41 100644
--- a/README.md
+++ b/README.md
@@ -309,13 +309,13 @@ The firmware can only be built on Linux currently. For Windows use WSL.
    For Ubuntu/Debian:
    ```bash
    sudo apt install --yes \
+    acpica-tools \
     build-essential \
     device-tree-compiler \
     g++ \
     gcc \
     gcc-aarch64-linux-gnu \
     git \
-    iasl \
     python-is-python3 \
     python3 \
     python3-pyelftools \
diff --git a/edk2-rockchip/Platform/OrangePi/OrangePi5Pro/OrangePi5Pro.dsc b/edk2-rockchip/Platform/OrangePi/OrangePi5Pro/OrangePi5Pro.dsc
index 35f942e8..ddfa003f 100644
--- a/edk2-rockchip/Platform/OrangePi/OrangePi5Pro/OrangePi5Pro.dsc
+++ b/edk2-rockchip/Platform/OrangePi/OrangePi5Pro/OrangePi5Pro.dsc
@@ -82,16 +82,20 @@
   #
   # PCIe/SATA/USB Combo PIPE PHY support flags and default values
   #
-  gRK3588TokenSpaceGuid.PcdComboPhy0Switchable|TRUE
-  gRK3588TokenSpaceGuid.PcdComboPhy2Switchable|TRUE
+  gRK3588TokenSpaceGuid.PcdComboPhy0Switchable|FALSE
+  gRK3588TokenSpaceGuid.PcdComboPhy1Switchable|TRUE
+  gRK3588TokenSpaceGuid.PcdComboPhy2Switchable|FALSE
   gRK3588TokenSpaceGuid.PcdComboPhy0ModeDefault|$(COMBO_PHY_MODE_PCIE)
-  gRK3588TokenSpaceGuid.PcdComboPhy2ModeDefault|$(COMBO_PHY_MODE_USB3)
+  gRK3588TokenSpaceGuid.PcdComboPhy1ModeDefault|$(COMBO_PHY_MODE_PCIE)
+  gRK3588TokenSpaceGuid.PcdComboPhy2ModeDefault|$(COMBO_PHY_MODE_PCIE)
 
   #
   # USB/DP Combo PHY support flags and default values
   #
   gRK3588TokenSpaceGuid.PcdUsbDpPhy0Supported|TRUE
+  gRK3588TokenSpaceGuid.PcdUsbDpPhy1Supported|TRUE
   gRK3588TokenSpaceGuid.PcdDp0LaneMux|{ 0x2, 0x3 }
+  gRK3588TokenSpaceGuid.PcdDp1LaneMux|{ 0x0 }   
 
   #
   # GMAC