Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework Crunchbase example to latest revisions of FIBO #2008

Closed
VladimirAlexiev opened this issue Apr 11, 2024 · 10 comments
Closed

rework Crunchbase example to latest revisions of FIBO #2008

VladimirAlexiev opened this issue Apr 11, 2024 · 10 comments

Comments

@VladimirAlexiev
Copy link

This is a really great example. Any chance we can update it to use the latest revisions to FIBO, including migration of some ontologies to the OMG's Commons Ontology Library 1.1 standard? I would be happy to walk through that with you :).

Originally posted by @ElisaKendall in #1816 (comment)

@VladimirAlexiev
Copy link
Author

VladimirAlexiev commented Apr 11, 2024

hi @ElisaKendall, I would be very glad to do it!

I think the most efficient way is if you submit a PR against https://github.com/VladimirAlexiev/crunchbase-fibo: files
prefixes.ttl ipos-agents.ttl ipos-offering.ttl ipos-financials.ttl ipos-currencies.ttl.
Then I'll check (read about) all the changes and if warranted add a section describing the evolution.

Or do you prefer to do it in some other way?

PS: I'd appreciate a suggestion for a journal where it could be published. Thanks!

@ElisaKendall
Copy link
Contributor

@VladimirAlexiev I'll think about the journal, but will work on this in your crunchbase git repo. I'll likely need your assistance to test it though. I will send email once I've made some progress so that you can take a look :).

On places to publish, I'll also think about that. Possibly an EU conference since you are there. Thanks!

@ElisaKendall
Copy link
Contributor

@VladimirAlexiev I think I've made a first pass for you, but you need to give me permission to write to a separate branch in your crunchbase-fibo repo in order to push the changes out :)

@VladimirAlexiev
Copy link
Author

VladimirAlexiev commented Apr 12, 2024

@ElisaKendall can you fork my repo to ElisaKendall/crunchbase-fibo? After pushing your changes there, Github will show you a link at your page that allows you to make a PR.

@ElisaKendall
Copy link
Contributor

@VladimirAlexiev hmmm - I cloned it and created a branch. I was attempting to push my branch to the remote repo, not push anything into the main branch, but I don't have permission to do that. Would it be ok to simply push the branch or do I really need to fork it?

@VladimirAlexiev
Copy link
Author

@ElisaKendall
You need to fork it as ElisaKendall/crunchbase-fibo. ("Clone" just means that you get a local copy).

@ElisaKendall
Copy link
Contributor

ElisaKendall commented Apr 14, 2024

@VladimirAlexiev Ok - done. We use branches for our FIBO work, but only because there are a small number of contributors that work with a larger SME community.

Let me know if this was enough for you to be able to address any other discrepancies you've found. I recommend updating this and other demos with the Q1 2024 FIBO release to catch things up with where we are, if possible.

@tahoeblue
Copy link

tahoeblue commented Apr 14, 2024 via email

@VladimirAlexiev
Copy link
Author

VladimirAlexiev commented Apr 14, 2024

Thanks @ElisaKendall ! Normally you'd make a branch for each task/feature. But since here is only one task (to update), it's ok that you did it in your Master.
I left a couple of comments, please take a look. But I'll merge it now and will proceed to regenerate the figures and add a few more editorial things (which prefixes were changed).

@tahoeblue

Truth be told, these are not very semantic:

  • Elisa forked my repo so I can review her changes. That's the normal way to collaborate on Github.

@VladimirAlexiev
Copy link
Author

VladimirAlexiev commented Apr 14, 2024

@mereolog mereolog added this to the 2024Q2 FIBO Release milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants