Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batching of LineStrips #33

Open
questor opened this issue Jul 1, 2024 · 1 comment
Open

Batching of LineStrips #33

questor opened this issue Jul 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@questor
Copy link

questor commented Jul 1, 2024

Hi!
I'm using your project and had a small issue with automatic batching. When drawing LineStrips it's automatically batching the strips which results in wrong draw lines between the original commands. Think about draw strip 1 (with points 0,1,2,3) and strip 2 (with points 4,5,6,7) and batching will concat the calls will result in a wrongly drawn line between point 3 and point 4).

For my usecase it's fine to disable automatically batching, but I think the call that checks if batching is possible should forbid a merge between line-strips (triangle-strips might also be impacted).

Thanks for your library, it's helping my toy-projects a lot!

@edubart edubart added the bug Something isn't working label Jul 1, 2024
@edubart
Copy link
Owner

edubart commented Jul 1, 2024

Oh this really looks like a bug, will take a look eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants