-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add UV alignment, orientation instructions in volume meta.json #113
Comments
There are a few considerations to include here, and it should be inclusive of other manuscript forms like books/codices, not just scrolls. Do these variables (names could probably be improved) cover it? vc_render could then make informed choices about UV rotation and flip, as well as normal vector orientation.
|
Internally, this functionality has been desired for a long time, and I think it would dramatically improve the interpretability of An idea from years ago was to annotate the volume with landmarks which could then be used as orientation references. This has a theoretical advantage of being able to support auto-alignment for sample types beyond books and scrolls, or even just books or scrolls in a weird scan orientation. That said, it would be a complicated system, so I don't think it's necessarily worth doing at the moment unless this strikes someone's particular fancy. I like this generally, and I haven't fully thought through edge cases for this, but some initial thoughts:
|
What problem is your feature request solving?
Scrolls can be scanned upright or upside down, and slice ordering has two possibilities. Each combination requires inputting different --uv-align-to-axis or --uv-flip, uv-rotate operations into vc_render to orient the flattened segment properly for reading.
What is your feature request?
We should add support for volume-specific uv orientation instructions to the volume meta.json
What alternative solutions have you considered?
Edit all volumes: use the internal spiral information to rotate all volumes to be "upright and to have the same slice ordering. Downsides are the possibility of making mistakes, and the presence of uncorrected volumes already released to the public.
Is there anything else we should know that wasn't included already?
No response
Are you proposing to work on this feature yourself?
Code of Conduct
The text was updated successfully, but these errors were encountered: