gfmpw1 run-precheck Makefile target uses -it, breaks github actions

[mattvenn]

Since commit 9ee2462 by @marwaneltoukhy

-it has been added to the docker precheck target.

What is the reasoning behind that? It means the precheck now fails in a github action.

[marwaneltoukhy]

It was added so that docker runs interactively so you can kill the process if needed, when running locally.

[mattvenn]

interesting. That doesn't actually work for me, I have to open a new terminal and docker kill it. Is there a way where it could tell if it has terminal and only then uses -it? For now I'm just removing -it so I can run it as a GH action: https://github.com/mattvenn/project0_test/actions/runs/6878330117/workflow#L43