New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global-greedy-dag sometimes extracts nodes from the wrong class #28

Open

TrevorHansen opened this issue Dec 27, 2023 · 0 comments

Contributor

TrevorHansen commented Dec 27, 2023

With the extra checking in #26, global-greedy-dag now fails because it selects nodes from the wrong class:

target/release/extraction-gym data/eggcc-bril/duplicate_branch.bril.json --extractor=global-greedy-dag --out=output/eggcc-bril/duplicate_branch.bril.json-global-greedy-dag.json
iteration 1
iteration 2
iteration 3
iteration 4
iteration 5
iteration 6
thread 'main' panicked at 'assertion failed: node.eclass == *cid', src/extract/mod.rs:84:13

Previously this wasn't detected. I realised when global-greedy-dag has some extractions with a lower dag-cost than the optimal.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment