Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding https example . Best way is ? #12

Closed
gedw99 opened this issue Aug 6, 2024 · 6 comments
Closed

Adding https example . Best way is ? #12

gedw99 opened this issue Aug 6, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@gedw99
Copy link

gedw99 commented Aug 6, 2024

Only tested on local lan to laptop but should really work.

Wondering if it needs https, or its the secure cookie problem...

https://caniuse.com/?search=webauthn shows it should work :)

photo_2024-08-06 13 48 38

@gedw99 gedw99 changed the title safari IOS fails safari IOS: "WebAuthn is not supported in this browser" Aug 6, 2024
@egregors egregors added the bug Something isn't working label Aug 6, 2024
@egregors
Copy link
Owner

egregors commented Aug 6, 2024

I'm going to try to deploy _example app under Lets Encrypt SSL to be sure that the problem is not in HTTPs.

@gedw99
Copy link
Author

gedw99 commented Aug 7, 2024

You can just use caddy too . Local host will then be https://.

if you need a Caddyfile for it just shout. I can also PR it too

@egregors
Copy link
Owner

egregors commented Aug 8, 2024

I can confirm, that this issue is not reproducing when app with passkey deployed with SSL. Some info in PR #17

Let's rename this issue and use it to discuss adding HTTPS example?

@gedw99
Copy link
Author

gedw99 commented Aug 8, 2024

I can confirm, that this issue is not reproducing when app with passkey deployed with SSL. Some info in PR #17

Let's rename this issue and use it to discuss adding HTTPS example?

Ok sounds good 👌

I renamed the issue

@gedw99 gedw99 changed the title safari IOS: "WebAuthn is not supported in this browser" Adding https example . Best way is ? Aug 8, 2024
@egregors
Copy link
Owner

egregors commented Aug 8, 2024

Will you add a traefik sample then?

Absolutely! It'll be great if you can do that. Let's put all this stuff inside _example. It could be a part of #19 activity.

How do you think, should we separate examples in _example (I mean: one for just go app, one – with SSL on localhost, one – for prod ready and so on) or it looks like overkill for now?

@gedw99
Copy link
Author

gedw99 commented Aug 10, 2024

Let’s try 2 examples I guess . Maybe after we understand the ports thing it will be a single example again .

it’s best you do the traefik bits. Have not touched it for years .

@egregors egregors self-assigned this Aug 10, 2024
egregors added a commit that referenced this issue Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants